https://bugzilla.redhat.com/show_bug.cgi?id=2283281 wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lukasz.wojnilowic | |z@xxxxxxxxx) | --- Comment #10 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #7) > Spec URL: https://eclipseo.fedorapeople.org/for-review/python-pyshacl.spec > SRPM URL: > https://eclipseo.fedorapeople.org/for-review/python-pyshacl-0.26.0-1.fc40. > src.rpm > > > Yes good idea, I implemented the conditional build. Thanks. That looks good. Shouldn't %{?with_http:x http} be %{?with_http:-x http} ? The first one would expand to "%pyproject_buildrequires -t x http" but I believe you need "%pyproject_buildrequires -t -x http" > I split the patch in 2 to be cleared: > - one patch to drop the pyshacl-cli.spec from install > - one patch to relax the poetry dependencies, which will be dropped when > F40 is EOL. I'm not sure that helped. You don't see /usr/lib/python3.12/site-packages/pyshacl/pyshacl-cli.spec after installing your python3-pyshacl-0.26.0-1.fc40.noarch.rpm? I still do. The package stopped building on rawhide. I don't see this as gating in the review template, but do you want to work it out before committing this package? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283281 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283281%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
