Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: db4 https://bugzilla.redhat.com/show_bug.cgi?id=225675 limb@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From limb@xxxxxxxxxxxx 2008-01-24 13:08 EST ------- rpmlint on srpm: Lots of unversioned obsoletes, but since they're for db3, db2, etc, so I think that's ok. db4.src: W: mixed-use-of-spaces-and-tabs (spaces: line 133, tab: line 4) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. Cosmetic, but easy to fix. db4.src: W: invalid-license BSD-style Change to BSD. No documentation warnings for -cxx, -tcl packages. db4-java.i386: W: devel-file-in-non-devel-package /usr/lib/libdb_java-4.6.a db4-tcl.i386: W: devel-file-in-non-devel-package /usr/lib/libdb_tcl-4.6.a db4-utils.i386: E: non-standard-executable-perm /usr/bin/db_deadlock 0555 And many other in /usr/bin. These need to be corrected or explained in spec. There are .la files in some packages. These are not allowed, and should either be removed or be justified in the spec. Same goes for static libs. If they are needed by a dependent package, state this in the spec. Other than the above, no other blockers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review