https://bugzilla.redhat.com/show_bug.cgi?id=2279057 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #15 from Jerry James <loganjerry@xxxxxxxxx> --- I want to apologize for the silence. I had a giant pile of work dropped on me, then I went on vacation, then I came home to another giant pile of work. I've been slowly catching up with Fedora tasks and am finally reaching the review requests. I should be more responsive now. Your responses to my concerns all seem quite reasonable. I am happy with the current state of the package. This package is APPROVED. (In reply to wojnilowicz from comment #9) > I've found one more missing license. Could you check if it's OK now? Good catch! Yes, that looks fine. > Since I don't bundle any npm package and it's marked as "recommended", I > just didn't include it. I've included it now. Okay, that makes sense. If you don't think it adds value, then feel free to remove it again. > I investigated it further and here are my findings: > 1) aw-qt uses logo.png and logo-128.png from Source3 > 2) aw-webui uses only logo.png and logo.svg from Source3 > > I just added linked those two files directly from the GitHub. Please take a > look. Should it still ba a separate aw-media package, then I can do it. Okay, I'm fine with that approach for now. If more packages show up that need those files, then an aw-media package would be the way to go. > I removed it altogether and it works still. Okay. I see the CSS file falls back to "sans-serif" if the font is not available, so that should be okay. > It's only a build dependency for aw-server-rust. aw-server-rust embeds it in > its executable file. Do you think this package should require nodejs then? I'm asking these questions because I don't know the answers. :-) If it doesn't really require nodejs, then by all means omit it. > Is it about all licenses listed above or only about missing Apache-2.0 and > OFL-1.1-RFN? The latter. The rest are due to licensecheck looking through the bundled nodejs files. > Was it only about varela-round-latin? That and the media files. I'm satisfied with your answers. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279057 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279057%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
