https://bugzilla.redhat.com/show_bug.cgi?id=2283281 wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lukasz.wojnilowic | |z@xxxxxxxxx) | --- Comment #6 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- Thanks. Everything seems OK, except this "5) Done. Removed through the patch to the pyproject.toml." pyshacl-cli.spec is still there and following comment "# Also remove extra spec file for win32 cli, keep ths one." doesn't do what it says. There is also a typo in "keep ths one." Did you mean "keep this one", like specifically python-pyshacl.spec? It's a bit difficult to understand. I would remove either pyshacl-cli.spec or this comment and the hunk of it in the patch. After all I cannot find anywhere that I should review with respect to bloat files :) You also have several lines commented out due to the extra dependencies for http and explained it only at one of the commented lines. Please take it as a suggestion only: I think it would look better with the use of: 1) %bcond http 0 2) %{?with_http:-x http} 3) %if %{with http} yourcode %endif as can be seen at https://rathann.fedorapeople.org/review/python-detect-secrets/python-detect-secrets.spec ("%bcond gibberish 0" specifically) https://src.fedoraproject.org/rpms/workrave/blob/rawhide/f/workrave.spec ("%{?with_mate:ON}" specifically) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283281 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283281%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
