https://bugzilla.redhat.com/show_bug.cgi?id=2283281 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(lukasz.wojnilowic | |z@xxxxxxxxx) --- Comment #4 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- Spec URL: https://eclipseo.fedorapeople.org/for-review/python-pyshacl.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/python-pyshacl-0.26.0-1.fc40.src.rpm Thank you for the review! 1) Weird, it seems I hadn't built it yet but this bug 2) Man page added. I had to remove pyshacl_server because it was not functionnal. It depends on -x http which needs extra deps which I am not willing to spend time on. 3) Done with fdupes 4) chmod +x the cli file 5) Done. Removed through the patch to the pyproject.toml. 6) Already fixed on my local file, apparently. 7) I will target F40 too, I relaxed the poetry and poetry-core dependencies. They bumped it for Black, but we do not depend on this for the build process. Fedora-review on my COPR: Rawhide: https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/fedora-rawhide-x86_64/07610451-python-pyshacl/fedora-review/review.txt F40: https://download.copr.fedorainfracloud.org/results/eclipseo/scancode-toolkit/fedora-40-x86_64/07610451-python-pyshacl/fedora-review/review.txt My builds: https://copr.fedorainfracloud.org/coprs/eclipseo/scancode-toolkit/build/7610451/ Happy RPMLint: Rpmlint ------- Checking: python3-pyshacl-0.26.0-1.fc41.noarch.rpm python-pyshacl-0.26.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpys5cklk6')] checks: 32, packages: 2 python-pyshacl.src: E: spelling-error ('validator', 'Summary(en_US) validator -> lavatorial') python-pyshacl.src: E: spelling-error ('rdflib', '%description -l en_US rdflib -> rifling') python3-pyshacl.noarch: E: spelling-error ('validator', 'Summary(en_US) validator -> lavatorial') python3-pyshacl.noarch: E: spelling-error ('rdflib', '%description -l en_US rdflib -> rifling') python3-pyshacl.noarch: W: cross-directory-hard-link /usr/lib/python3.12/site-packages/pyshacl/constraints/sparql/__init__.py /usr/lib/python3.12/site-packages/pyshacl/constraints/core/__init__.py 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 12 filtered, 4 badness; has taken 0.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "python3-pyshacl". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283281 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283281%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
