https://bugzilla.redhat.com/show_bug.cgi?id=2254709 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |dominik@xxxxxxxxxxxxxx --- Comment #9 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- Taking review. Quick notes: 1. %{_libdir}/libCuteLogger.so A shared library without SONAME in %{_libdir} should be moved out of linker search path, e.g. to %{_libdir}/%{name} if it's not supposed to be available for consumption by other packages. You might need to apply https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning otherwise. This is highlighted by rpmlint, too: shotcut.x86_64: E: invalid-soname /usr/lib64/libCuteLogger.so libCuteLogger.so 2. Requires: ffmpeg must be changed to e.g. Requires: /usr/bin/ffmpeg 3. Patch0: Force_X.patch Fedora is Wayland by default, so any deviations should be explained. Is there an upstream bug report? 4. It might be worth using a macro for org.%{name}.Shotcut string, which gets repeated multiple times in the spec. 5. There are multiple duplicate files: shotcut.x86_64: E: files-duplicated-waste 779412 shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/bigsh0t_rect_to_eq/icon.webp /usr/share/shotcut/qml/filters/bigsh0t_eq_to_rect/icon.webp shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/select0r/icon.webp /usr/share/shotcut/qml/filters/bluescreen0r/icon.webp:/usr/share/shotcut/qml/filters/mask_chromakey/icon.webp shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/blur_lowpass/icon.webp /usr/share/shotcut/qml/filters/blur_exponential/icon.webp:/usr/share/shotcut/qml/filters/blur_gaussian/icon.webp shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/gpstext/vui.qml /usr/share/shotcut/qml/filters/dynamictext/vui.qml shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/fadein_movit/icon.webp /usr/share/shotcut/qml/filters/fadein_brightness/icon.webp shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/fadeout_movit/icon.webp /usr/share/shotcut/qml/filters/fadeout_brightness/icon.webp shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/lenscorrection/icon.webp /usr/share/shotcut/qml/filters/fisheye/icon.webp shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/vaguedenoiser/icon.webp /usr/share/shotcut/qml/filters/fspp/icon.webp:/usr/share/shotcut/qml/filters/hqdn3d/icon.webp:/usr/share/shotcut/qml/filters/noise_fast/icon.webp:/usr/share/shotcut/qml/filters/smartblur/icon.webp shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/vibrance/icon.webp /usr/share/shotcut/qml/filters/hue_lightness_saturation/icon.webp shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/spectrum/vui_spectrum.qml /usr/share/shotcut/qml/filters/lightshow/vui.qml shotcut.x86_64: W: files-duplicate /usr/share/shotcut/qml/filters/mask_shape/icon.webp /usr/share/shotcut/qml/filters/mask_alphaspot/icon.webp Consider hardlinking them to save space. 6. # The entire source code is GPLv3+ except mvcp/ which is LGPLv2+ License: GPL-3.0-or-later AND LGPL-2.1-or-later Licensing needs an update: * mvcp is no longer there * CuteLogger is LGPL 2.1 only (source code doesn't mention "or any later version") and I'm not sure if it can be combined with GPL 3.0 as-is. ./CuteLogger/include/AbstractAppender.h: LGPL-2.1 ./CuteLogger/include/AbstractStringAppender.h: LGPL-2.1 ./CuteLogger/include/ConsoleAppender.h: LGPL-2.1 ./CuteLogger/include/FileAppender.h: LGPL-2.1 ./CuteLogger/include/Logger.h: LGPL-2.1 ./CuteLogger/include/OutputDebugAppender.h: LGPL-2.1 ./CuteLogger/src/AbstractAppender.cpp: LGPL-2.1 ./CuteLogger/src/AbstractStringAppender.cpp: LGPL-2.1 ./CuteLogger/src/ConsoleAppender.cpp: LGPL-2.1 ./CuteLogger/src/FileAppender.cpp: LGPL-2.1 ./CuteLogger/src/Logger.cpp: LGPL-2.1 ./CuteLogger/src/OutputDebugAppender.cpp: LGPL-2.1 * spatialmedia is Apache-licensed: ./src/spatialmedia/box.cpp: Apache-2.0 ./src/spatialmedia/box.h: Apache-2.0 ./src/spatialmedia/constants.h: Apache-2.0 ./src/spatialmedia/container.cpp: Apache-2.0 ./src/spatialmedia/container.h: Apache-2.0 ./src/spatialmedia/mpeg4_container.cpp: Apache-2.0 ./src/spatialmedia/mpeg4_container.h: Apache-2.0 ./src/spatialmedia/sa3d.cpp: Apache-2.0 ./src/spatialmedia/sa3d.h: Apache-2.0 ./src/spatialmedia/spatialmedia.cpp: Apache-2.0 ./src/spatialmedia/spatialmedia.h: Apache-2.0 * There's a bunch of bundled JavaScript, which is MIT licensed: ./doc/html/clipboard.js: MIT ./doc/html/dynsections.js: MIT ./doc/html/jquery.js: MIT ./doc/html/menu.js: MIT ./doc/html/menudata.js: MIT ./doc/html/resize.js: MIT -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2254709 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202254709%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
