https://bugzilla.redhat.com/show_bug.cgi?id=2279967 --- Comment #10 from Jakub Jelen <jjelen@xxxxxxxxxx> --- Just a few notes and then I think we are good: Wording: - Development files with include files to develop applications + Development files with header files to develop applications Duplicated files: openpace-doc.noarch: E: files-duplicated-waste 237297 openpace-doc.noarch: W: files-duplicate /usr/share/doc/openpace/_static/bootswatch-2.3.2/img/glyphicons-halflings-white.png /usr/share/doc/openpace/_static/bootstrap-2.3.2/img/glyphicons-halflings-white.png openpace-doc.noarch: W: files-duplicate /usr/share/doc/openpace/_static/bootswatch-2.3.2/img/glyphicons-halflings.png /usr/share/doc/openpace/_static/bootstrap-2.3.2/img/glyphicons-halflings.png openpace-doc.noarch: W: files-duplicate /usr/share/doc/openpace/_static/bootswatch-3.3.7/fonts/glyphicons-halflings-regular.eot /usr/share/doc/openpace/_static/bootstrap-3.3.7/fonts/glyphicons-halflings-regular.eot openpace-doc.noarch: W: files-duplicate /usr/share/doc/openpace/_static/bootswatch-3.3.7/fonts/glyphicons-halflings-regular.svg /usr/share/doc/openpace/_static/bootstrap-3.3.7/fonts/glyphicons-halflings-regular.svg openpace-doc.noarch: W: files-duplicate /usr/share/doc/openpace/_static/bootswatch-3.3.7/fonts/glyphicons-halflings-regular.ttf /usr/share/doc/openpace/_static/bootstrap-3.3.7/fonts/glyphicons-halflings-regular.ttf openpace-doc.noarch: W: files-duplicate /usr/share/doc/openpace/_static/bootswatch-3.3.7/fonts/glyphicons-halflings-regular.woff /usr/share/doc/openpace/_static/bootstrap-3.3.7/fonts/glyphicons-halflings-regular.woff openpace-doc.noarch: W: files-duplicate /usr/share/doc/openpace/_static/bootswatch-3.3.7/fonts/glyphicons-halflings-regular.woff2 /usr/share/doc/openpace/_static/bootstrap-3.3.7/fonts/glyphicons-halflings-regular.woff2 The fonts are packaged in Fedora separately so I would remove them (both occurrences) from the -doc package and add them as a dependency on the following package https://src.fedoraproject.org/rpms/glyphicons-halflings-fonts according to the guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/ For the autotools I opened an issue here: https://pagure.io/FedoraReview/issue/520 Regarding the spelling error openpace.x86_64: E: spelling-error ('Cryptographic', 'Summary(en_US) Cryptographic -> Cryptography, Cryptographer, Crystallographic') I would propose to add this exception to the rpmlintrc, similarly as we have it for example here: https://src.fedoraproject.org/rpms/openssh/blob/rawhide/f/openssh.rpmlintrc It will avoid going over the same error over and over again when we belive it is correctly spelled. Last, in files, there are quite wide wildcards such as %{_mandir}/man1/cvc* or %{_libdir}/pkgconfig/*.pc -- I think we should be more specific at least in these cases to make sure we dont match anything else we do not want and we can notice possible changes. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2279967 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279967%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
