Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: documentation-devil - Documentation tool chain https://bugzilla.redhat.com/show_bug.cgi?id=427481 ------- Additional Comments From bkoz@xxxxxxxxxx 2008-01-24 10:48 EST ------- Here are some issues that I think should be addressed before this package is pushed out into Fedora: 1) duplication of xsl stylsheets between docbook-style-xsl-1.73.2-4.fc8 documentation-devel-0.26-1.fc8 Specific files and directories: /usr/share/documentation-devel/xsl/docbook/1.72.0/* Instead, documentation-devel should depend on docbook-style-xsl and reference those stylesheets. 2) The Red Hat and Red Hat product parts of the Makefile.common should be removed. These belong in the Red Hat specific packages, not in a general thing. IE: /usr/share/documentation-devel/make/Makefile.common: %grep Red Makefile.* Makefile.common:#Makefile for Red Hat Documentation Makefile.common:#Copyright Red Hat Inc. 2006 Makefile.common:ifeq "$(PRODUCT)" "Red_Hat_Enterprise_Linux" 3) invalid XHTML for "html" make target. There is already a bug report about this: https://bugzilla.redhat.com/show_bug.cgi?id=428931 "By hand" docbook with the current FC8 toolchain validates as XHTML 1.0, so this should too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review