[Bug 2283055] Review Request: supernovas - The SuperNOVAS C/C++ astrometry library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2283055

Daniel Berrangé <berrange@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |berrange@xxxxxxxxxx



--- Comment #38 from Daniel Berrangé <berrange@xxxxxxxxxx> ---
> > > - rpmlint warning
> > > supernovas-cio-data.x86_64: W: only-non-binary-in-usr-lib
> > > Is the cio_ra.bin an executable? Or it's just a resource? If the latter,
> > > maybe it can be moved under %{_datadir}/%{name}?
> > 
> > It is a resource but it is a platform-dependent one -- so it has an 'arch'
> > dependence. %{_datadir} has no arch-dependence, but %{_libdir} does, which
> > is why I thought this resource might fit there best. Or do you think it's
> > better to put arch-dependent data into {%_datadir}, perhaps under a
> > %{name}/%{_isa} directory instead?
> > 
>
> mmm I'll ask for that too, I don't think I've never encountered such a situation...

What Attila has done is fine. If the data resource is built in an architecture
dependent format, then using %{_libdir}/%{name}/ is a suitable approach to
take. This is just a warning in rpmlint, rather than an error, as a way to
remind people to double-check suitability for %{_libdir} special cases.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2283055

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283055%23c38
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux