https://bugzilla.redhat.com/show_bug.cgi?id=2281588 Tomi Lähteenmäki <lihis@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(zebob.m@xxxxxxxxx | |) --- Comment #9 from Tomi Lähteenmäki <lihis@xxxxxxxxx> --- Thank you so much for the review! All things should be now fixed. From the personal preference ones, I added the "v" for rm but left out the "rf" so I don't forget to drop it if the static library is no longer installed. The "systemd-rpm-macros" however, the build fails with this if it is not in BuildRequires: > RPM build errors: > File must begin with "/": %{_udevrulesdir}/*.rules > File must begin with "/": %{_udevhwdbdir}/*.hwdb what would be proper way to fix this? Attaching the URLs with the fixed spec even tho the build fails: Spec URL: https://download.copr.fedorainfracloud.org/results/lihis/gmobile/fedora-rawhide-x86_64/07578549-gmobile/gmobile.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lihis/gmobile/fedora-rawhide-x86_64/07578549-gmobile/gmobile-0.2.0-4.fc41.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2281588 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202281588%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue