https://bugzilla.redhat.com/show_bug.cgi?id=2281588 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx CC| |zebob.m@xxxxxxxxx Status|NEW |ASSIGNED Flags| |fedora-review? --- Comment #7 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Add the COPYING.LIB license file: %license COPYING COPYING.LIB - Breakdown the licenses as a comment: # LGPL-2.1-or-later: src/ # GPL-3.0-or-later: examples/ tests/ - Source0 Not need to suffix with 0 anymore. Same for patches. - I don't see any systemd service files, so you don't need BuildRequires: systemd-rpm-macros - Build the documentation: %bcond docs 1 ... %if %{with docs} BuildRequires: gi-docgen BuildRequires: python3dist(docutils) %endif ... %if %{with docs} %package docs Summary: Documentation for the gmobile library # LGPL-2.1-or-later: # - *.html # Apache-2.0 OR GPL-3.0-or-later: # - fonts.css # - main.js # - search.js # - style.css # GPL-3.0-or-later: # - urlmap.js # MIT: # - fzy.js # - solarized-dark.css # - solarized-light.css License: LGPL-2.1-or-later AND GPL-3.0-or-later AND (Apache-2.0 OR GPL-3.0-or-later) AND MIT %description docs Documentation for the gmobile library. %endif ... %meson \ %if %{with docs} -Dgtk_doc=true \ -Dman=true \ %endif -Dexamples=false ... %files %doc README.md %license COPYING COPYING.LIB %{_libdir}/libgmobile.so.0 %{_libdir}/girepository-1.0 %if %{with docs} %{_mandir}/man5/gmobile.udev.5.* %endif %{_udevrulesdir}/*.rules %{_udevhwdbdir}/*.hwdb ... %if %{with docs} %files docs %license COPYING COPYING.LIB %doc examples/ %{_docdir}/gmobile-0/ %endif - Don't put a period at the end of devel Summary - Personal preferences, do what you want with that: Preemptively consider Epoch: Requires: %{name}%{?_isa} = %{version}-%{release} -> Requires: %{name} = %{?epoch:%{epoch}:}%{version}-%{release} Use rm -v for confirmation in the logs, and %{buildroot} instead of ${RPM_BUILD_ROOT}/ rm ${RPM_BUILD_ROOT}/%{_libdir}/libgmobile.a -> rm -rfv %{buildroot}%{_libdir}/libgmobile.a - Proposed full spec: %bcond docs 1 Name: gmobile Version: 0.2.0 Release: %autorelease Summary: Functions useful in mobile related, glib based projects # LGPL-2.1-or-later: src/ # GPL-3.0-or-later: examples/ tests/ License: LGPL-2.1-or-later AND GPL-3.0-or-later URL: https://gitlab.gnome.org/World/Phosh/gmobile Source: %{url}/-/archive/v%{version}/gmobile-v%{version}.tar.gz BuildRequires: gcc BuildRequires: marshalparser BuildRequires: meson BuildRequires: pkgconfig(gio-2.0) >= 2.66 BuildRequires: pkgconfig(glib-2.0) >= 2.66 BuildRequires: pkgconfig(gobject-introspection-1.0) BuildRequires: pkgconfig(json-glib-1.0) >= 1.6.2 %if %{with docs} BuildRequires: gi-docgen BuildRequires: python3dist(docutils) %endif Requires: systemd-udev %description gmobile carries some helpers for glib based environments on mobile devices. %package devel Summary: Development headers for the gmobile library Requires: %{?epoch:%{epoch}:}%{version}-%{release} %description devel Development headers for the gmobile library. %if %{with docs} %package docs Summary: Documentation for the gmobile library # LGPL-2.1-or-later: # - *.html # Apache-2.0 OR GPL-3.0-or-later: # - fonts.css # - main.js # - search.js # - style.css # GPL-3.0-or-later: # - urlmap.js # MIT: # - fzy.js # - solarized-dark.css # - solarized-light.css License: LGPL-2.1-or-later AND GPL-3.0-or-later AND (Apache-2.0 OR GPL-3.0-or-later) AND MIT %description docs Documentation for the gmobile library. %endif %prep %autosetup -p1 -n %{name}-v%{version} %build %meson \ %if %{with docs} -Dgtk_doc=true \ -Dman=true \ %endif -Dexamples=false %meson_build %install %meson_install rm ${RPM_BUILD_ROOT}/%{_libdir}/libgmobile.a %check %meson_test %files %doc README.md %license COPYING COPYING.LIB %{_libdir}/libgmobile.so.0 %{_libdir}/girepository-1.0 %if %{with docs} %{_mandir}/man5/gmobile.udev.5.* %endif %{_udevrulesdir}/*.rules %{_udevhwdbdir}/*.hwdb %files devel %{_includedir}/gmobile %{_libdir}/libgmobile.so %{_libdir}/pkgconfig/gmobile.pc %{_datadir}/gir-1.0 %if %{with docs} %files docs %license COPYING COPYING.LIB %doc examples/ %{_docdir}/gmobile-0/ %endif %changelog %autochangelog --- Review template: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "*No copyright* GNU Lesser General Public License, Version 2.1", "GNU General Public License v3.0 or later and/or GNU Lesser General Public License v3.0 or later and/or GNU Lesser General Public License, Version 2.1", "GNU General Public License, Version 3". 68 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gmobile/review-gmobile/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1250 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gmobile-0.2.0-1.fc41.x86_64.rpm gmobile-devel-0.2.0-1.fc41.x86_64.rpm gmobile-debuginfo-0.2.0-1.fc41.x86_64.rpm gmobile-debugsource-0.2.0-1.fc41.x86_64.rpm gmobile-0.2.0-1.fc41.src.rpm ========================================================= rpmlint session starts ========================================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpv1hovj9s')] checks: 32, packages: 5 gmobile-devel.x86_64: W: summary-ended-with-dot Development headers for the gmobile library. gmobile-devel.x86_64: W: no-documentation =================== 5 packages and 0 specfiles checked; 0 errors, 2 warnings, 30 filtered, 0 badness; has taken 0.5 s ==================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 gmobile-devel.x86_64: W: summary-ended-with-dot Development headers for the gmobile library. gmobile-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings, 26 filtered, 0 badness; has taken 0.4 s NEEDINFO me for followpup. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2281588 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202281588%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
