[Bug 2283055] Review Request: supernovas - The SuperNOVAS C/C++ astrometry library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2283055



--- Comment #33 from Mattia Verga <mattia.verga@xxxxxxxxx> ---
A few issues while reviewing the package:

- Sources in the SRPM does not match with those downloaded from the upstream
URL

- No known owner of /usr/lib64/supernovas
Perhaps the -cio-data subpackage should just own the entire %{_libdir}/%{name}
directory?

- Macros in: supernovas (description)
I think this error is due to the presence of a '%' character in the
description. It should be escaped (I think using a double '%%')

- rpmlint errors
supernovas-solsys2.x86_64: E: undefined-non-weak-symbol
/usr/lib64/libsolsys2.so.1.0.1 novas_trace     
(/usr/lib64/libsolsys2.so.1.0.1)
supernovas-solsys2.x86_64: E: undefined-non-weak-symbol
/usr/lib64/libsolsys2.so.1.0.1 jplint_  (/usr/lib64/libsolsys2.so.1.0.1)
supernovas-solsys2.x86_64: E: undefined-non-weak-symbol
/usr/lib64/libsolsys2.so.1.0.1 novas_error     
(/usr/lib64/libsolsys2.so.1.0.1)
supernovas-solsys2.x86_64: E: undefined-non-weak-symbol
/usr/lib64/libsolsys2.so.1.0.1 jplihp_  (/usr/lib64/libsolsys2.so.1.0.1)

- rpmlint warning
supernovas-cio-data.x86_64: W: only-non-binary-in-usr-lib
Is the cio_ra.bin an executable? Or it's just a resource? If the latter, maybe
it can be moved under %{_datadir}/%{name}?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2283055

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283055%23c33
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux