https://bugzilla.redhat.com/show_bug.cgi?id=2290665 --- Comment #4 from Aurelien Bompard <aurelien@xxxxxxxxxxx> --- > The URL field could be https instead of http Fixed, thanks. > I don't think you need the rm -rf $RPM_BUILDROOT I've used the spectemplate that comes with rpmdevtools, it's apparently still there. I've removed it, it's been optional for ages. > The changelog entry is for 1.0.0-1, the version in the spec is 1.0.1-1 Good catch! > I'd recommend using %autorelease and %autochangelog, but I'm guessing this is heading for EPEL repositories and maybe those macros aren't available? Either way, not deal-breakers. Yeah, it'll have to go to both Fedora and EPEL > I think that spelling is fine and clear. It definitely shouldn't be "integration's". Thanks. > It does seem the package depends on a deprecated version of sqlalchemy (but presumably not deprecated in EPEL?). It's actually compatible with SQLAlchemy 1.4 and 2.x, I test it in tox (but not in this package, it just runs pytest). It's 1.4 though, not 1.3, I'll fix it upstream for the next release. Thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2290665 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202290665%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
