Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kde-style-domino - KDE style with a soft look https://bugzilla.redhat.com/show_bug.cgi?id=249236 thomas.moschny@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thomas.moschny@xxxxxx ------- Additional Comments From thomas.moschny@xxxxxx 2008-01-24 05:09 EST ------- What's the status of this package? (In reply to comment #13) > It doesn't build on mock. rpmlint are Ok. Which spec/srpm are you referring to? The one made by Kelly or the the one made by http://liviopl.fedorapeople.org/domino.spec ? > Some issues that should be fixed: > - Put all .la file on a -devel package .la files are special and needed for kde addon packages. This has been explained earlier. Same for .desktop here. > - Use "3" suffix to kde-packages (if possible) Don't think so, as this package is going to be approved for F-7 and F-8 only. > - Build require /usr/lib/libkdecorations.la (kdebase-libs) > require /usr/include/kde/kcommondecoration.h (kdebase3-devel who require > kdebase-libs, and kdelibs3-devel) Should be "BuildRequires: kdebase-devel". > - call ldconfig in %post & %postun Not needed, as %{_libdir}/kde3 is not one of the dynamic linker's default paths. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review