https://bugzilla.redhat.com/show_bug.cgi?id=2282603 --- Comment #6 from Bill Roberts <bill.roberts@xxxxxxx> --- > Consider adding README.md, SUPPORT.md and SECURITY.md to the documentation in the main package Is their an example package with these? Or some guidelines of what they should include? > Why is %ldconfig_scriptlets needed? Can probably be dropped. Copy paste from previous mbedtls.spec file, and yes it can be dropped. > Can non-network tests be run? Their testing framework is insane, it actually builds the source multiple times and would need a lot of work to get it to function like a traditional build system. `--except` is handy, but you essentially end up removing all the tests because they all build the source. > doc package should also have license file as it does not require the main package Fixed. > Sonames should not be globbed: Fixed > Maybe it is better to add a patch to the CMake configuration to enable installation in a prefixed > directory, rather than moving after doing the install. This may be useful for other distributions, > so having it upstream will reduce reduplicated efforts. I can work on upstreaming something. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2282603 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202282603%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
