https://bugzilla.redhat.com/show_bug.cgi?id=2283517 wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(decathorpe@gmail. | |com) --- Comment #2 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > Some minor issues: > > - If you apply patches to Cargo.toml, please use "rust2rpm -p". It is the > only supported mechanism for doing so. Done. > - Please add some kind of comment, and if possible, link to upstream commit > / PR for the redfa bump. I've added a comment explaining why I did so. There is no upstream commit. plex was updated 8 and redfa 6 months ago, so the newer redfa had no chance to be included in the current plex. We could bump the version ourselves as I did or I could request redfa0.0.2 (which is 7 years old) and package it just like the current plex requires. What do you think we should do? [fedora-review-service-build] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2283517 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283517%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
