https://bugzilla.redhat.com/show_bug.cgi?id=2284460 --- Comment #2 from Sandro <gui1ty@xxxxxxxxxxxxx> --- Thank you for the points raised. (In reply to Felix Wang from comment #1) > 1) the tests on ppc64le failed, > https://copr.fedorainfracloud.org/coprs/topazus/test-review/build/7527702/ So far, I only built the package on x86_64. I will check with upstream regarding support for ppc64le. > 2) There are files in ANNarchy/include directory, which are under > GPL-3.0-or-later license. > > > License: GPL-2.0-or-later AND MIT Right. Changing the license string is easy. But that leaves us without the license text for GPL-3.0-or-later. I'll ask upstream why they have mixed preambles in the header files. > > 3) The -devel sub-package is not packaged with header files, it is in > python3-annarchy. I'm aware. However, I think that is acceptable for Python packages. At least `numpy` is doing the same. And I'm not aware of any arched Python packages shipping devel sub packages. With regards to `numpy`, it seems to be required for the header files to be shipped and installed the way they are. There is a function for getting the include path, `numpy.get_include()`, which returns `/usr/lib64/python3.12/site-packages/numpy/core/include`. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2284460 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202284460%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
