https://bugzilla.redhat.com/show_bug.cgi?id=2274747 --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> --- 1) gcc command should be used with macro and not explicit list of compile flags. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags and https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#_macros_providing_compiler_and_linker_flags 2) if package is providing header files then it should go to separate package. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages 3) when installing files, timestamp should be preserved. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps 4) License text for Zlib is not present in source archive. Ask upstream to add Zlib license text in upstream as a separate file. 5) library file libtinyfd.so should be handled properly for installation see https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages 6) don't use strip and debug_package macro -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2274747 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274747%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
