https://bugzilla.redhat.com/show_bug.cgi?id=2283850 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > I do, but I just copy the contents to extra-patches so that it is more easily reproducible, and it doesn't affect the spec file itself, so it can be placed in either patch. I would strongly recommend *not* to do this: It gives you only additional work for zero benefits. Patches for Cargo.toml (i.e. with "rust2rpm -p") almost always need to be rebased for every version. So the only thing you get is divergence from other Rust packages and additional manual work every time (renaming files and removing the generated patch from the spec file). You can save comments that apply to a manually created Cargo.toml patch with the "package.cargo-toml-patch-comments" setting. I would recommend to use this instead of abusing the "extra-patches" setting for this, which is *not* what it is intended to do. (I should know, I implemented this feature in rust2rpm.) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283850 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283850%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
