Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: cyrus-sasl https://bugzilla.redhat.com/show_bug.cgi?id=225673 limb@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From limb@xxxxxxxxxxxx 2008-01-23 14:26 EST ------- rpmlint on srpm: cyrus-sasl.src: W: strange-permission make-no-dlcompatorsrp-tarball.sh 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. cyrus-sasl.src: W: strange-permission saslauthd.init 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. Probably acceptable. rpmlint on rpms: cyrus-sasl.i386: E: executable-marked-as-config-file /etc/rc.d/init.d/saslauthd Executables must not be marked as config files because that may prevent upgrades from working correctly. If you need to be able to customize an executable, make it for example read a config file in /etc/sysconfig. cyrus-sasl.i386: W: conffile-without-noreplace-flag /etc/rc.d/init.d/saslauthd A configuration file is stored in your package without the noreplace flag. A way to resolve this is to put the following in your SPEC file: %config(noreplace) /etc/your_config_file_here Fix these, or explain in spec. cyrus-sasl.i386: W: incoherent-init-script-name saslauthd The init script name should be the same as the package name in lower case, or one with 'd' appended if it invokes a process by that name. Would correcting this break anything? cyrus-sasl-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/cyrus-sasl-2.1.22/include/sasl.h The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. cyrus-sasl-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/cyrus-sasl-2.1.22/include/saslplug.h The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. cyrus-sasl-debuginfo.i386: W: spurious-executable-perm /usr/src/debug/cyrus-sasl-2.1.22/include/hmac-md5.h The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. These need fixing. cyrus-sasl-devel.i386: W: no-dependency-on cyrus-sasl Fix. cyrus-sasl-gssapi.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. cyrus-sasl-ldap.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. cyrus-sasl-md5.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. cyrus-sasl-ntlm.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. cyrus-sasl-plain.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. cyrus-sasl-sql.i386: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. Can probably ignore, but I'd rather see it fixed if there are docs that are broken out into similar units as the packages. Source0: tag needs to include the url to the tarball included in the SRPM. IF this is a modified version of an upstream tarball, provide a script that converts the upstream tarball into the one provided. The Guidelines forbid the inclusion of .la files, these should be removed. Other than the above, no blockers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review