https://bugzilla.redhat.com/show_bug.cgi?id=2260598 --- Comment #19 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #17) > > %{__cargo} run manpage $utility > data/man/man1/uu_${utility}.1 > > This is bad in two ways - the __cargo macro is for internal use only (hence > two underscores), and the CLI command isn't even right (missing "--" between > "run" and "manpage"). > > When / if you enable this, you can use something like this: > > target/rpm/coreutils manpage $utility > data/man/man1/uu_${utility}.1 > > Please also move the "mkdir -p data/man/man1" into the "with man" > conditional. > > Both are harmless since the manpages are not built yet, so just suggestions > for improvement. > Thanks! Applied now so I don't forget for later. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2260598 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260598%23c19 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
