https://bugzilla.redhat.com/show_bug.cgi?id=2260598 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #17 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > %{__cargo} run manpage $utility > data/man/man1/uu_${utility}.1 This is bad in two ways - the __cargo macro is for internal use only (hence two underscores), and the CLI command isn't even right (missing "--" between "run" and "manpage"). When / if you enable this, you can use something like this: target/rpm/coreutils manpage $utility > data/man/man1/uu_${utility}.1 Please also move the "mkdir -p data/man/man1" into the "with man" conditional. Both are harmless since the manpages are not built yet, so just suggestions for improvement. Other than that, package looks good to me now. Thank you for investigating the test failures! Hopefully we can reduce the number of ignored tests in the future ... === Package was generated with rust2rpm, simplifying the review. ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (some failing tests ignored for now) 🫤 latest version of the crate is packaged (version matches existing uu_* packages) ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2260598 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260598%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
