https://bugzilla.redhat.com/show_bug.cgi?id=2279967 Jakub Jelen <jjelen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |jjelen@xxxxxxxxxx Flags| |fedora-review? CC| |jjelen@xxxxxxxxxx --- Comment #5 from Jakub Jelen <jjelen@xxxxxxxxxx> --- * The created directories should be specified in %files section such as %dir %{_sysconfdir}/eac/ or %dir %{_includedir}/eac/ (there are more if I see right) * Requires: %{name}-libs%{?_isa} = %{version}-%{release} the subpaackage -libs does not exist. I think this should be just the dependency on the main package * Package should not use obsolete m4 macros: https://fedorahosted.org/FedoraReview/wiki/AutoTools -- there is problematic use of AC_PROG_LIBTOOL -- would be worth investigating if this could be changed (upstream first) * openpace.x86_64: W: non-conffile-in-etc /etc/eac/cvc/DECVCAEPASS00102 -- files in /etc should be %config * Why did not you package the documentation? openpace-devel.x86_64: W: no-documentation -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279967 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279967%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
