https://bugzilla.redhat.com/show_bug.cgi?id=2262767 --- Comment #5 from Jens Petersen <petersen@xxxxxxxxxx> --- (In reply to Jens Petersen from comment #4) > Thanks, overall looks fine to me. > > The package complies with the packaging guidelines, builds and installs. > Spec file is generated with cabal-rpm. > > However the license file is MIT, but many of the source files say ISC > (except .cabal). > Could you confirm the license with the upstream maintainer, please? > (I know ISC and MIT are quite similar but we need to be precise in Fedora: > in the worst case we could possibly go with "MIT AND ISC" as workaround but > that feels wrong: > maybe ISC is more correct actually here by the looks of it.) Indeed: https://github.com/glguy/config-value/issues/13 So either add a link to this issue above the corrected License field, or update to the newer release if that comes out first and is compatible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262767 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262767%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
