Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: timidity++ https://bugzilla.redhat.com/show_bug.cgi?id=226492 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-23 13:19 EST ------- License check list: =========================================================== Source: GPLv2+ interface/VTparse.h MIT interface/VTPrsTbl.c MIT interface/xaw_redef.c MIT timidity/mt19937ar.c BSD utils/fft4g.c Okay! utils/fft4g.h Okay! http://www.kurims.kyoto-u.ac.jp/~ooura/fft-j.html Source1,3,4: SourceURL links broken, and all binaries. What are these files? Maybe Public Domain? or like "Redistributable, no modification permitted"? =========================================================== For 2.13.2-6: * Documents - Please add some documents to %doc * At least "COPYING" must be added * And consider to add some other documents such as ---------------------------------------------------------- TiMidity++-2.13.2/AUTHORS TiMidity++-2.13.2/ChangeLog* TiMidity++-2.13.2/README* (TiMidity++-2.13.2/README.ja is encoded in EUC-JP) ---------------------------------------------------------- * Also please check man files ---------------------------------------------------------- TiMidity++-2.13.2/doc/ja_JP.eucJP/timidity.1 (EUC-JP) timidity.cfg.5 (Same as above) ---------------------------------------------------------- ! Note If you are willing to support Japanese man page, it - must be converted from EUC-JP to UTF-8 (by iconv, for example) - must be placed on %_mandir/ja/man1/timidity.1* - and must be marked as %lang(ja). * Obsoletes - Please change Obsoletes to at least version specific (and why is this Obsoletes needed?) * Parallel make - Please check if parallel make is possible. * Timestamps - When using "cp" or "install" commands, please add "-p" option to keep timestamps. * Verbose output - Any reason you want to use tar x"v"jf? (note that for %setup Fedora requests that it should be quiet) * Hardcorded /etc - Is the reason you are using hardcorded /etc is the existence of Patch(0)? If so I was told to remove hardcoded path by like below: ------------------------------------------------------------- %setup -q -n TiMidity++-%{version} %Patch ......... # Ensure that we are actually using %%_sysconfdir sed -i.path -e 's|/etc/timidity\.cfg|%{_sysconfdir}/timidity.cfg|' \ timidity/timidity.h %build ------------------------------------------------------------- and replace all /etc with %_sysconfdir. I also think this is better. Or maybe it can be replaced by below? -------------------------------------------------------------- export EXTRACFLAGS="$RPM_OPT_FLAGS -DCONFIG_FILE=\"%{_sysconfdir}/timidity.cfg\"" -------------------------------------------------------------- * rpmlint - Only one thing: ------------------------------------------------------------- timidity++-patches.i386: W: symlink-should-be-relative /usr/share/timidity/timidity.cfg /etc/timidity.cfg ------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review