https://bugzilla.redhat.com/show_bug.cgi?id=2275305 Sandro <gui1ty@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |gui1ty@xxxxxxxxxxxxx CC| |gui1ty@xxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED --- Comment #1 from Sandro <gui1ty@xxxxxxxxxxxxx> --- I'm taking this. Seems I might need it for another package I'm working on. Glancing over the spec file, I have the following preliminary remarks: In `setup.py` upstream defines extra `preview`. That should be packaged as such. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Extras However, since glfw-preview [1] is not yet packaged for Fedora, you can leave out the extra. On the other hand, `glfw-preview` uses the same source as `glfw`, so it seems reasonable to package that as well. It should probably be a package of its own, but I'll check on that. You should use the modern Python (pyproject) macros described in [2], unless there's a compelling reason for using the older macros [3]. Using the modern macros, you should not need to specify any Provides or Requires. They will be detected and added automatically. You have `Requires: python3dist(glfw-preview)`. That seems wrong since only the optional `preview` extra requires it. It also causes the package not to install since nothing provides `python3dist(glfw-preview)`. The modern macros will also make it easy to populate the `%files` section (see [4]). Lastly, please consider defining a macro for the description instead of repeating the content. See the example spec file [4] for inspiration. It will make maintaining the spec file easier. [1] https://pypi.org/project/glfw-preview/ [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/ [4] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2275305 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202275305%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
