[Bug 2235055] Review Request: scancode-toolkit - Scan code and detect licenses, copyrights, and more.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2235055



--- Comment #18 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
The summary should not end with a dot.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

The patch should have linked the upstream issue or commented on why it was
added.
https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/

Otherwise, it looks good. 
Please build new spdx-tools in rawhide and update the above nitpicks and I will
approve.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2235055

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202235055%23c18
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux