https://bugzilla.redhat.com/show_bug.cgi?id=2282603 --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: mbedtls3.6.spec should be mbedtls-3.6.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [!]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/cmake(rizin-devel, PackageKit-Qt5-devel, pulseaudio-libs-devel, libarcus-devel, openobex- devel, boost-devel, PackageKit-Qt6-devel, priv_wrapper, qt5-qtbase, qjson-qt5-devel, paraview-devel, leatherman-devel, catalyst-devel, marble-widget-qt5-devel, kqtquickcharts, marble-astro-devel, qjson- devel, cmake-filesystem, libsavitar-devel, uid_wrapper, ginac-devel, SDL2_image-devel), /usr/lib64/pkgconfig(dontpanic-devel, ignition- math-devel, pcsc-lite-devel, libmodsecurity-devel, bemenu-devel, ignition-transport-devel, mbedtls-devel, nexus-devel, pkgconf-pkg- config, libloc-devel, priv_wrapper, uid_wrapper, xalan-c-devel) [ ]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 336367 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/fedora/2282603-mbedtls3.6/srpm- unpacked/mbedtls3.6.spec See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: mbedtls-3.6-3.6.0-1.fc41.aarch64.rpm mbedtls-3.6-devel-3.6.0-1.fc41.aarch64.rpm mbedtls-3.6-doc-3.6.0-1.fc41.noarch.rpm mbedtls-3.6-debuginfo-3.6.0-1.fc41.aarch64.rpm mbedtls-3.6-debugsource-3.6.0-1.fc41.aarch64.rpm mbedtls-3.6-3.6.0-1.fc41.src.rpm ===================================================== rpmlint session starts ===================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpaafneafd')] checks: 32, packages: 6 mbedtls-3.6-devel.aarch64: W: unstripped-binary-or-object /usr/lib64/libeverest-3.6.so mbedtls-3.6-devel.aarch64: W: unstripped-binary-or-object /usr/lib64/libp256m-3.6.so mbedtls-3.6-devel.aarch64: E: shared-library-not-executable /usr/lib64/libeverest-3.6.so mbedtls-3.6-devel.aarch64: E: shared-library-not-executable /usr/lib64/libp256m-3.6.so mbedtls-3.6-devel.aarch64: E: non-devel-file-in-devel-package /usr/lib64/libeverest-3.6.so mbedtls-3.6-devel.aarch64: E: non-devel-file-in-devel-package /usr/lib64/libp256m-3.6.so mbedtls-3.6-devel.aarch64: W: no-documentation mbedtls3.6.spec:55: W: mixed-use-of-spaces-and-tabs (spaces: line 30, tab: line 55) mbedtls3.6.spec:89: W: macro-in-comment %check mbedtls3.6.spec:90: W: macro-in-comment %ctest mbedtls-3.6.src: E: invalid-spec-name mbedtls-3.6.aarch64: W: incoherent-version-in-changelog 3.6.0 ['3.6.0-1.fc41', '3.6.0-1'] mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/dot_inline_dotgraph_2.png /usr/share/doc/mbedtls-3.6/dot_inline_dotgraph_1.png mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/groups_0.js /usr/share/doc/mbedtls-3.6/search/all_1.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/variables_13.js /usr/share/doc/mbedtls-3.6/search/all_16.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/groups_14.js /usr/share/doc/mbedtls-3.6/search/all_18.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/variables_15.js /usr/share/doc/mbedtls-3.6/search/all_1a.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/pages_1.js /usr/share/doc/mbedtls-3.6/search/all_2.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/variables_0.js /usr/share/doc/mbedtls-3.6/search/all_3.js =============== 6 packages and 0 specfiles checked; 5 errors, 14 warnings, 53 filtered, 5 badness; has taken 3.4 s =============== Rpmlint (debuginfo) ------------------- Checking: mbedtls-3.6-debuginfo-3.6.0-1.fc41.aarch64.rpm ===================================================== rpmlint session starts ===================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1_iw2_dp')] checks: 32, packages: 1 =============== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 0.4 s ================ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 mbedtls-3.6-devel.aarch64: W: unstripped-binary-or-object /usr/lib64/libeverest-3.6.so mbedtls-3.6-devel.aarch64: W: unstripped-binary-or-object /usr/lib64/libp256m-3.6.so mbedtls-3.6-devel.aarch64: E: shared-library-not-executable /usr/lib64/libeverest-3.6.so mbedtls-3.6-devel.aarch64: E: shared-library-not-executable /usr/lib64/libp256m-3.6.so mbedtls-3.6-devel.aarch64: E: non-devel-file-in-devel-package /usr/lib64/libeverest-3.6.so mbedtls-3.6-devel.aarch64: E: non-devel-file-in-devel-package /usr/lib64/libp256m-3.6.so mbedtls-3.6-devel.aarch64: W: no-documentation mbedtls-3.6.aarch64: W: incoherent-version-in-changelog 3.6.0 ['3.6.0-1.fc41', '3.6.0-1'] mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/dot_inline_dotgraph_2.png /usr/share/doc/mbedtls-3.6/dot_inline_dotgraph_1.png mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/groups_0.js /usr/share/doc/mbedtls-3.6/search/all_1.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/variables_13.js /usr/share/doc/mbedtls-3.6/search/all_16.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/groups_14.js /usr/share/doc/mbedtls-3.6/search/all_18.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/variables_15.js /usr/share/doc/mbedtls-3.6/search/all_1a.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/pages_1.js /usr/share/doc/mbedtls-3.6/search/all_2.js mbedtls-3.6-doc.noarch: W: files-duplicate /usr/share/doc/mbedtls-3.6/search/variables_0.js /usr/share/doc/mbedtls-3.6/search/all_3.js 5 packages and 0 specfiles checked; 4 errors, 11 warnings, 50 filtered, 4 badness; has taken 3.3 s Source checksums ---------------- https://github.com/Mbed-TLS/mbedtls/releases/download/v3.6.0/mbedtls-3.6.0.tar.bz2 : CHECKSUM(SHA256) this package : 3ecf94fcfdaacafb757786a01b7538a61750ebd85c4b024f56ff8ba1490fcd38 CHECKSUM(SHA256) upstream package : 3ecf94fcfdaacafb757786a01b7538a61750ebd85c4b024f56ff8ba1490fcd38 Requires -------- mbedtls-3.6 (rpmlib, GLIBC filtered): ld-linux-aarch64.so.1()(64bit) libc.so.6()(64bit) libmbedcrypto-3.6.so.16()(64bit) libmbedx509-3.6.so.7()(64bit) rtld(GNU_HASH) mbedtls-3.6-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(aarch-64) libmbedcrypto-3.6.so.16()(64bit) libmbedtls-3.6.so.21()(64bit) libmbedx509-3.6.so.7()(64bit) mbedtls-3.6(aarch-64) pkgconfig(mbedcrypto-3.6) pkgconfig(mbedx509-3.6) rtld(GNU_HASH) mbedtls-3.6-doc (rpmlib, GLIBC filtered): mbedtls-3.6-debuginfo (rpmlib, GLIBC filtered): mbedtls-3.6-debugsource (rpmlib, GLIBC filtered): Provides -------- mbedtls-3.6: libmbedcrypto-3.6.so.16()(64bit) libmbedtls-3.6.so.21()(64bit) libmbedx509-3.6.so.7()(64bit) mbedtls-3.6 mbedtls-3.6(aarch-64) mbedtls-3.6-devel: cmake(MbedTLS) cmake(mbedtls) libeverest-3.6.so()(64bit) libp256m-3.6.so()(64bit) mbedtls-3.6-devel mbedtls-3.6-devel(aarch-64) pkgconfig(mbedcrypto-3.6) pkgconfig(mbedtls-3.6) pkgconfig(mbedx509-3.6) mbedtls-3.6-doc: mbedtls-3.6-doc mbedtls-3.6-debuginfo: debuginfo(build-id) libmbedcrypto-3.6.so.3.6.0-3.6.0-1.fc41.aarch64.debug()(64bit) libmbedtls-3.6.so.3.6.0-3.6.0-1.fc41.aarch64.debug()(64bit) libmbedx509-3.6.so.3.6.0-3.6.0-1.fc41.aarch64.debug()(64bit) mbedtls-3.6-debuginfo mbedtls-3.6-debuginfo(aarch-64) mbedtls-3.6-debugsource: mbedtls-3.6-debugsource mbedtls-3.6-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2282603 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: SugarActivity, Python, Perl, Haskell, Java, fonts, PHP, R, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Consider adding README.md, SUPPORT.md and SECURITY.md to the documentation in the main package b) Why is %ldconfig_scriptlets needed? Can probably be dropped. c) Can non-network tests be run? d) doc package should also have license file as it does not require the main package e) Sonames should not be globbed: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_soname_handling f) Maybe it is better to add a patch to the CMake configuration to enable installation in a prefixed directory, rather than moving after doing the install. This may be useful for other distributions, so having it upstream will reduce reduplicated efforts. g) In Fedora, generally the latest release gets a name without a version attached. May wish to co-ordinate with current Mbed TLS 2.28 maintainers about naming. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2282603 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202282603%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
