https://bugzilla.redhat.com/show_bug.cgi?id=2219137 --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present. Note: Javadocs are optional for Fedora versions >= 21 See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation - Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated". 29 files have unknown license. Detailed output of licensecheck in /home/fedora/2219137-apfloat/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1077 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in apfloat- applet , apfloat-calc , apfloat-samples [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: apfloat-1.10.1-1.fc41.noarch.rpm apfloat-applet-1.10.1-1.fc41.noarch.rpm apfloat-calc-1.10.1-1.fc41.noarch.rpm apfloat-samples-1.10.1-1.fc41.noarch.rpm apfloat-1.10.1-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpmcskel2c')] checks: 32, packages: 5 apfloat.noarch: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat.src: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat-applet.noarch: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat-calc.noarch: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat-samples.noarch: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat-applet.noarch: W: no-documentation apfloat-calc.noarch: W: no-documentation apfloat-samples.noarch: W: no-documentation apfloat.noarch: W: file-not-utf8 /usr/share/doc/apfloat/README.md apfloat-calc.noarch: W: class-path-in-manifest /usr/share/java/apfloat/apfloat-calc.jar apfloat-samples.noarch: W: class-path-in-manifest /usr/share/java/apfloat/apfloat-samples.jar 5 packages and 0 specfiles checked; 5 errors, 6 warnings, 20 filtered, 5 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 apfloat-applet.noarch: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat-samples.noarch: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat-calc.noarch: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat.noarch: E: spelling-error ('lang', '%description -l en_US lang -> Lang, lag, slang') apfloat-applet.noarch: W: no-documentation apfloat-samples.noarch: W: no-documentation apfloat-calc.noarch: W: no-documentation apfloat.noarch: W: file-not-utf8 /usr/share/doc/apfloat/README.md apfloat-samples.noarch: W: class-path-in-manifest /usr/share/java/apfloat/apfloat-samples.jar apfloat-calc.noarch: W: class-path-in-manifest /usr/share/java/apfloat/apfloat-calc.jar 4 packages and 0 specfiles checked; 4 errors, 6 warnings, 16 filtered, 4 badness; has taken 0.4 s Source checksums ---------------- https://github.com/mtommila/apfloat/archive/1.10.1/apfloat-1.10.1.tar.gz : CHECKSUM(SHA256) this package : a5692c21e899ba68235882f1d1f124b03abd1138e48a31adcf7ac0a4e68fa80b CHECKSUM(SHA256) upstream package : a5692c21e899ba68235882f1d1f124b03abd1138e48a31adcf7ac0a4e68fa80b Requires -------- apfloat (rpmlib, GLIBC filtered): (java-headless or java-21-headless or java-17-headless or java-11-headless or java-1.8.0-headless) javapackages-filesystem apfloat-applet (rpmlib, GLIBC filtered): (java-headless or java-21-headless or java-17-headless or java-11-headless or java-1.8.0-headless) javapackages-filesystem mvn(org.apfloat:apfloat) apfloat-calc (rpmlib, GLIBC filtered): (java-headless or java-21-headless or java-17-headless or java-11-headless or java-1.8.0-headless) javapackages-filesystem mvn(org.apfloat:apfloat) apfloat-samples (rpmlib, GLIBC filtered): (java-headless or java-21-headless or java-17-headless or java-11-headless or java-1.8.0-headless) javapackages-filesystem mvn(org.apfloat:apfloat) Provides -------- apfloat: apfloat mvn(org.apfloat:apfloat) mvn(org.apfloat:apfloat:pom:) apfloat-applet: apfloat-applet mvn(org.apfloat:apfloat-applet) mvn(org.apfloat:apfloat-applet:pom:) apfloat-calc: apfloat-calc mvn(org.apfloat:apfloat-calc) mvn(org.apfloat:apfloat-calc:pom:) apfloat-samples: apfloat-samples mvn(org.apfloat:apfloat-samples) mvn(org.apfloat:apfloat-samples:pom:) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2219137 Buildroot used: fedora-rawhide-aarch64 Active plugins: Shell-api, Generic, Java Disabled plugins: R, Ocaml, PHP, Python, Perl, fonts, SugarActivity, Haskell, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Thanks for packaging this. b) Please update to latest release 1.14.0 c) Should the package name be apfloat_java as there is a C++ version apfloat, see: http://www.apfloat.org/apfloat/ d) Javadoc package has bundled jquery. This should be indicated. Alternatively, use a different output format which does not add javascript. e) Should the samples subpackage also have a license file? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2219137 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202219137%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
