https://bugzilla.redhat.com/show_bug.cgi?id=2276336 --- Comment #6 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- The thing is that the comparison make sense when char is signed, and is harmless (as the warning says, “is always true due to limited range of data type”) when char is unsigned – the logic remains correct. It’s OK for the compiler to warn about it, but it doesn’t need to break the build. However, upstream passes -Werror, which asks the compiler to treat all warnings as errors. That’s useful for upstream development, but I think it’s too strict for downstream packaging across different compilers and platforms, where new warnings can pop up at any time. My intent was just to disable -Werror and ignore the warning in question with # Too strict for downstream packaging sed -r -i 's/-Werror\b//' test/CMakeLists.txt but obviously I didn’t get it quite right. I’ll fix this. Note that removing the comparison with 0 is *not* a correct general patch, because when char is signed char, this actually changes the behavior. One person offered a patch https://github.com/virtuosonic/loguru/commit/e1ffdc4149083cc221d44b666a0f7e3ec4a87259 that would explicitly use signed char, and that looks right, at a glance. Still, I like just disabling -Werror here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2276336 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276336%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
