https://bugzilla.redhat.com/show_bug.cgi?id=2244124 --- Comment #17 from Artem <ego.cordatus@xxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #16) > These directory are uncommon and are not owned by hicolor-icon-theme. Own them in your SPEC. This look like unnecessary files. I removed them for now and opened upstream issue https://github.com/crow-translate/crow-translate/issues/685. Waiting for upstream approval. > Seek a FPC exception for bundling 3rd party libraries, or package them. Nothing prevents you from doing it but you'all to modify the CMakelists. For example: Fedora guidelines says: > Fedora packages SHOULD make every effort to avoid having multiple, separate, upstream projects bundled together in a single package. Not MUST. And i already asked about this upstream. Also documented in Spec. Upstream answer is: > Consider submodules in this repo as a way to avoid copy-pasting the code I don't want patching this downstream and i don't want fight with upstream. I've already learned this lesson. If someone really wants this please submit upstream patch. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling --- New build: https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-rawhide-x86_64/07484998-crow-translate/crow-translate.spec https://download.copr.fedorainfracloud.org/results/atim/playground/fedora-rawhide-x86_64/07484998-crow-translate/crow-translate-2.11.1-1.fc41.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244124 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244124%23c17 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
