https://bugzilla.redhat.com/show_bug.cgi?id=2283055 Mattia Verga <mattia.verga@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mattia.verga@xxxxxxxxx Blocks| |177841 (FE-NEEDSPONSOR) Doc Type|--- |If docs needed, set a value --- Comment #5 from Mattia Verga <mattia.verga@xxxxxxxxx> --- A quick informal review: > Group: Development/Libraries The Group: tag SHOULD NOT be used. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > %package doc The -doc subpackage must require the main package, as it puts files under '%{_datadir}/%{name}' which is owned by the main package. > %install > rm -rf %{buildroot} The contents of the buildroot SHOULD NOT be removed in the first line of %install. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > %files Nothing owns %{_datadir}/%{name} You should explicitly add '%dir %{_datadir}/%{name}' > %doc %{_datadir}/%{name}/doc/* I think it's better to use '%doc %{_datadir}/%{name}/doc' so that the subpackage will own both the directory and its content. > %doc %{_mandir}/man3/* Files installed in %{_mandir} are automatically marked by RPM as documentation. Thus it is not necessary to use %doc. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2283055 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202283055%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
