https://bugzilla.redhat.com/show_bug.cgi?id=2252811 Paul Pfeister <rh-bugzilla@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rh-bugzilla@xxxxxxxxxxxx --- Comment #6 from Paul Pfeister <rh-bugzilla@xxxxxxxxxxxx> --- Hey Leonardo Fedora Review fails as the spec file isn't found in the srpm. Possibly due to the inconsistent naming between the package and file. If the package name is kconfiglib, the spec file should be kconfiglib.spec (won't be picked up by the review service otherwise). Otherwise... - The long-form description is too long for rpmlint - Package summary shouldn't end with a period - URL is duplicated in Source rather than using %{url} (doesn't break the package, just better for maintainability) - Files installed to site-packages should lose their shebang - No man pages for any of the installed Check out the changes suggested here: https://github.com/odra/kconfiglib-rpm/pull/1 (lack of man pages not addressed by that PR) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2252811 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202252811%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
