[Bug 2282872] Review Request: supernovas-libs - SuperNOVAS astrometry library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2282872

Mattia Verga <mattia.verga@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value
                 CC|                            |mattia.verga@xxxxxxxxx



--- Comment #14 from Mattia Verga <mattia.verga@xxxxxxxxx> ---
It is not needed to package the -libs, -devel and -docs separately. You should
use just one main source package and use subpackages. For example look at
https://src.fedoraproject.org/rpms/wcstools/blob/rawhide/f/wcstools.spec

Usually you should name the source package just as upstream (supernovas) and
then provide the subpackages. In your case I think you can avoid the -libs
subpackage and just use the main supernova package for that.

Also, have a look at https://docs.fedoraproject.org/en-US/packaging-guidelines/
there are some things to tweak (for example, you're missing BuildRequires: make
and you should not use rm -rf %{buildroot} )


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2282872

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202282872%23c14
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux