https://bugzilla.redhat.com/show_bug.cgi?id=2274250 --- Comment #8 from Davide Cavalca <davide@xxxxxxxxxxxx> --- (In reply to Tom Rix from comment #7) > When i do > > # rpm -ihv review-katago/results/katago-1.14.1-1.fc41.x86_64.rpm > error: Failed dependencies: > katago-backend = 1.14.1-1.fc41 is needed by katago-1.14.1-1.fc41.x86_64 > > Then i have to figure out which to use 'eigen' or 'opencl' > I think it would be easier on the user if the 'eigen' subpackage was > collapsed to the main package. This is a side effect of using rpm -i. If the packages are all in a repo and one does dnf install katago, dnf should automatically pull in the eigen subpackage. > The setup assumes the user is going to read the README.fedora. > I did not the first time. > > The nn url in the readme could be improved to > https://katagotraining.org/networks/ Will fix, thanks > Could a katago-setup setup script be added to automate the instructions ? Not easily, as there isn't a stable URL to the "last good network". We'd have to scrape it from that web page, which doesn't seem worth the trouble. > Some other nits from the review > katago.spec:40: W: unversioned-explicit-provides bundled(clblast) > > katago.spec:43: W: unversioned-explicit-provides bundled(sha2) > > Take a guess on the versions. These don't really _have_ a version unfortunately :( > katago.spec:60: W: mixed-use-of-spaces-and-tabs (spaces: line 12, tab: line > 60) Will fix, thanks. > Is there going to be a follow on gui package to go with this engine ? Yes, I have a half-done package for q5go I'm planning to submit for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2274250 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202274250%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
