[Bug 2278424] Review Request: python-myst-nb - Jupyter Notebook Sphinx reader

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2278424

Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
             Status|NEW                         |ASSIGNED
                 CC|                            |zebob.m@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zebob.m@xxxxxxxxx



--- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
- License is unclear, I opened a bug report:
https://github.com/executablebooks/MyST-NB/issues/602

 - Use pytest for tests are %tox is not running them"

BuildRequires:  python3-pytest

%if %{with test}
%check
%pytest
%endif

Some will fail. Most likely due too matplotlib being newer than the one
expected upstream.
Disable the failing test with -k, and report the bug upstream:

+ /usr/bin/pytest
============================= test session starts
==============================
platform linux -- Python 3.12.3, pytest-7.4.3, pluggy-1.3.0
rootdir: /builddir/build/BUILD/MyST-NB-1.1.0
configfile: tox.ini
plugins: anyio-3.7.1, datadir-1.5.0, regressions-2.5.0, cov-4.0.0,
pytest_param_files-0.3.4
collected 80 items
tests/test_ansi_lexer.py ...........                                     [ 13%]
tests/test_cli.py ..                                                     [ 16%]
tests/test_codecell_file.py ..                                           [ 18%]
tests/test_docutils.py ..............                                    [ 36%]
tests/test_eval.py .                                                     [ 37%]
tests/test_execute.py .............FF........FF                          [ 68%]
tests/test_glue.py .....                                                 [ 75%]
tests/test_parser.py ....                                                [ 80%]
tests/test_render_outputs.py .............                               [ 96%]
tests/test_text_based.py ...                                             [100%]
=================================== FAILURES
===================================
_______________________ test_complex_outputs_unrun_cache
_______________________
sphinx_run = <conftest.SphinxFixture object at 0x7f7abd3a9a30>
file_regression = <conftest.FileRegression object at 0x7f7abd400ec0>
check_nbs = <function check_nbs.<locals>._check_nbs at 0x7f7abd3fb920>
    @pytest.mark.sphinx_params(
        "complex_outputs_unrun.ipynb", conf={"nb_execution_mode": "cache"}
    )
    def test_complex_outputs_unrun_cache(sphinx_run, file_regression,
check_nbs):
        sphinx_run.build()
        # print(sphinx_run.status())
        assert sphinx_run.warnings() == ""
>       regress_nb_doc(file_regression, sphinx_run, check_nbs)
/builddir/build/BUILD/MyST-NB-1.1.0/tests/test_execute.py:216: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/builddir/build/BUILD/MyST-NB-1.1.0/tests/test_execute.py:37: in regress_nb_doc
    file_regression.check(doctree_string, extension=".xml", encoding="utf-8")
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <conftest.FileRegression object at 0x7f7abd400ec0>
data = '<document source="complex_outputs_unrun"
translation_progress="{\'total\': 0, \'translated\': 0}">\n    <container ce...
            <emphasis>\n                                        some\n         
                           markdown\n'
kwargs = {'encoding': 'utf-8', 'extension': '.xml'}
    def check(self, data, **kwargs):
>       return self.file_regression.check(self._strip_ignores(data), **kwargs)
E       AssertionError: FILES DIFFER:
E      
/tmp/pytest-of-mockbuild/pytest-0/test_complex_outputs_unrun_cac0/test_execute/test_complex_outputs_unrun_cache.xml
E      
/tmp/pytest-of-mockbuild/pytest-0/test_complex_outputs_unrun_cac0/test_execute/test_complex_outputs_unrun_cache.obtained.xml
E       HTML DIFF:
/tmp/pytest-of-mockbuild/pytest-0/test_complex_outputs_unrun_cac0/test_execute/test_complex_outputs_unrun_cache.obtained.diff.html
E       --- 
E       +++ 
E       @@ -214,7 +214,7 @@
E                                    (√5⋅ⅈ)      ⋅⎜─ - ──────⎟ + (-√5⋅ⅈ)     
⋅⎜─ + ──────⎟
E                                                 ⎝2     5   ⎠                
⎝2     5   ⎠
E                            <container mime_type="image/png">
E       -                        <image candidates="{'*':
'_build/jupyter_execute/9bc81205a14646a235d284d1b68223d17f30f7f1d3d8ed3e52cf47830b02e3bb.png'}"
uri="_build/jupyter_execute/9bc81205a14646a235d284d1b68223d17f30f7f1d3d8ed3e52cf47830b02e3bb.png">
E       +                        <image candidates="{'*':
'_build/jupyter_execute/fd9ed1ea43d887584ea600fa27ca630752bf6f02d767def5675bcd5114ad03ba.png'}"
uri="_build/jupyter_execute/fd9ed1ea43d887584ea600fa27ca630752bf6f02d767def5675bcd5114ad03ba.png">
E                            <container mime_type="text/latex">
E                                <math_block classes="output text_latex"
nowrap="False" number="True" xml:space="preserve">
E                                    \displaystyle \left(\sqrt{5}
i\right)^{\alpha} \left(\frac{1}{2} - \frac{2 \sqrt{5} i}{5}\right) + \left(-
\sqrt{5} i\right)^{\alpha} \left(\frac{1}{2} + \frac{2 \sqrt{5} i}{5}\right)
/builddir/build/BUILD/MyST-NB-1.1.0/tests/conftest.py:286: AssertionError
----------------------------- Captured stderr call
-----------------------------
[IPKernelApp] WARNING | debugpy_stream undefined, debugging will not be enabled
_______________________ test_complex_outputs_unrun_auto
________________________
sphinx_run = <conftest.SphinxFixture object at 0x7f7abd3208c0>
file_regression = <conftest.FileRegression object at 0x7f7abd2fa9c0>
check_nbs = <function check_nbs.<locals>._check_nbs at 0x7f7abd33db20>
    @pytest.mark.sphinx_params(
        "complex_outputs_unrun.ipynb", conf={"nb_execution_mode": "auto"}
    )
    def test_complex_outputs_unrun_auto(sphinx_run, file_regression,
check_nbs):
        sphinx_run.build()
        # print(sphinx_run.status())
        assert sphinx_run.warnings() == ""
>       regress_nb_doc(file_regression, sphinx_run, check_nbs)
/builddir/build/BUILD/MyST-NB-1.1.0/tests/test_execute.py:237: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/builddir/build/BUILD/MyST-NB-1.1.0/tests/test_execute.py:37: in regress_nb_doc
    file_regression.check(doctree_string, extension=".xml", encoding="utf-8")
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <conftest.FileRegression object at 0x7f7abd2fa9c0>
data = '<document source="complex_outputs_unrun"
translation_progress="{\'total\': 0, \'translated\': 0}">\n    <container ce...
            <emphasis>\n                                        some\n         
                           markdown\n'
kwargs = {'encoding': 'utf-8', 'extension': '.xml'}
    def check(self, data, **kwargs):
>       return self.file_regression.check(self._strip_ignores(data), **kwargs)
E       AssertionError: FILES DIFFER:
E      
/tmp/pytest-of-mockbuild/pytest-0/test_complex_outputs_unrun_aut0/test_execute/test_complex_outputs_unrun_auto.xml
E      
/tmp/pytest-of-mockbuild/pytest-0/test_complex_outputs_unrun_aut0/test_execute/test_complex_outputs_unrun_auto.obtained.xml
E       HTML DIFF:
/tmp/pytest-of-mockbuild/pytest-0/test_complex_outputs_unrun_aut0/test_execute/test_complex_outputs_unrun_auto.obtained.diff.html
E       --- 
E       +++ 
E       @@ -214,7 +214,7 @@
E                                    (√5⋅ⅈ)      ⋅⎜─ - ──────⎟ + (-√5⋅ⅈ)     
⋅⎜─ + ──────⎟
E                                                 ⎝2     5   ⎠                
⎝2     5   ⎠
E                            <container mime_type="image/png">
E       -                        <image candidates="{'*':
'_build/jupyter_execute/9bc81205a14646a235d284d1b68223d17f30f7f1d3d8ed3e52cf47830b02e3bb.png'}"
uri="_build/jupyter_execute/9bc81205a14646a235d284d1b68223d17f30f7f1d3d8ed3e52cf47830b02e3bb.png">
E       +                        <image candidates="{'*':
'_build/jupyter_execute/fd9ed1ea43d887584ea600fa27ca630752bf6f02d767def5675bcd5114ad03ba.png'}"
uri="_build/jupyter_execute/fd9ed1ea43d887584ea600fa27ca630752bf6f02d767def5675bcd5114ad03ba.png">
E                            <container mime_type="text/latex">
E                                <math_block classes="output text_latex"
nowrap="False" number="True" xml:space="preserve">
E                                    \displaystyle \left(\sqrt{5}
i\right)^{\alpha} \left(\frac{1}{2} - \frac{2 \sqrt{5} i}{5}\right) + \left(-
\sqrt{5} i\right)^{\alpha} \left(\frac{1}{2} + \frac{2 \sqrt{5} i}{5}\right)
/builddir/build/BUILD/MyST-NB-1.1.0/tests/conftest.py:286: AssertionError
----------------------------- Captured stderr call
-----------------------------
[IPKernelApp] WARNING | debugpy_stream undefined, debugging will not be enabled
___________________________ test_custom_convert_auto
___________________________
sphinx_run = <conftest.SphinxFixture object at 0x7f7abd3a9e80>
file_regression = <conftest.FileRegression object at 0x7f7abd3afa40>
check_nbs = <function check_nbs.<locals>._check_nbs at 0x7f7abd28c360>
    @pytest.mark.sphinx_params(
        "custom-formats.Rmd",
        conf={
            "nb_execution_mode": "auto",
            "nb_custom_formats": {".Rmd": ["jupytext.reads", {"fmt": "Rmd"}]},
        },
    )
    def test_custom_convert_auto(sphinx_run, file_regression, check_nbs):
        sphinx_run.build()
        # print(sphinx_run.status())
        assert sphinx_run.warnings() == ""
>       regress_nb_doc(file_regression, sphinx_run, check_nbs)
/builddir/build/BUILD/MyST-NB-1.1.0/tests/test_execute.py:341: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/builddir/build/BUILD/MyST-NB-1.1.0/tests/test_execute.py:37: in regress_nb_doc
    file_regression.check(doctree_string, extension=".xml", encoding="utf-8")
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <conftest.FileRegression object at 0x7f7abd3afa40>
data = '<document source="custom-formats" translation_progress="{\'total\': 0,
\'translated\': 0}">\n    <section ids="custom...a5d7c3924be9.png"
uri="_build/jupyter_execute/d4af8d3724871916ca3dad388b7031ac3493074b53430101d6cea5d7c3924be9.png">\n'
kwargs = {'encoding': 'utf-8', 'extension': '.xml'}
    def check(self, data, **kwargs):
>       return self.file_regression.check(self._strip_ignores(data), **kwargs)
E       AssertionError: FILES DIFFER:
E      
/tmp/pytest-of-mockbuild/pytest-0/test_custom_convert_auto0/test_execute/test_custom_convert_auto.xml
E      
/tmp/pytest-of-mockbuild/pytest-0/test_custom_convert_auto0/test_execute/test_custom_convert_auto.obtained.xml
E       HTML DIFF:
/tmp/pytest-of-mockbuild/pytest-0/test_custom_convert_auto0/test_execute/test_custom_convert_auto.obtained.diff.html
E       --- 
E       +++ 
E       @@ -18,4 +18,4 @@
E                                <literal_block classes="output text_plain"
language="myst-ansi" xml:space="preserve">
E                                    <Figure size 640x480 with 1 Axes>
E                            <container mime_type="image/png">
E       -                        <image candidates="{'*':
'_build/jupyter_execute/a2e637020dfe58f670ba2c942d7a55e49ba48bed09312569ee15a84f5ac680cb.png'}"
uri="_build/jupyter_execute/a2e637020dfe58f670ba2c942d7a55e49ba48bed09312569ee15a84f5ac680cb.png">
E       +                        <image candidates="{'*':
'_build/jupyter_execute/d4af8d3724871916ca3dad388b7031ac3493074b53430101d6cea5d7c3924be9.png'}"
uri="_build/jupyter_execute/d4af8d3724871916ca3dad388b7031ac3493074b53430101d6cea5d7c3924be9.png">
/builddir/build/BUILD/MyST-NB-1.1.0/tests/conftest.py:286: AssertionError
----------------------------- Captured stderr call
-----------------------------
[IPKernelApp] WARNING | debugpy_stream undefined, debugging will not be enabled
__________________________ test_custom_convert_cache
___________________________
sphinx_run = <conftest.SphinxFixture object at 0x7f7abd7bb4a0>
file_regression = <conftest.FileRegression object at 0x7f7abd6f4890>
check_nbs = <function check_nbs.<locals>._check_nbs at 0x7f7abd2b3880>
    @pytest.mark.sphinx_params(
        "custom-formats.Rmd",
        conf={
            "nb_execution_mode": "cache",
            "nb_custom_formats": {".Rmd": ["jupytext.reads", {"fmt": "Rmd"}]},
        },
    )
    def test_custom_convert_cache(sphinx_run, file_regression, check_nbs):
        """The outputs should be populated."""
        sphinx_run.build()
        assert sphinx_run.warnings() == ""
>       regress_nb_doc(file_regression, sphinx_run, check_nbs)
/builddir/build/BUILD/MyST-NB-1.1.0/tests/test_execute.py:361: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/builddir/build/BUILD/MyST-NB-1.1.0/tests/test_execute.py:37: in regress_nb_doc
    file_regression.check(doctree_string, extension=".xml", encoding="utf-8")
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <conftest.FileRegression object at 0x7f7abd6f4890>
data = '<document source="custom-formats" translation_progress="{\'total\': 0,
\'translated\': 0}">\n    <section ids="custom...a5d7c3924be9.png"
uri="_build/jupyter_execute/d4af8d3724871916ca3dad388b7031ac3493074b53430101d6cea5d7c3924be9.png">\n'
kwargs = {'encoding': 'utf-8', 'extension': '.xml'}
    def check(self, data, **kwargs):
>       return self.file_regression.check(self._strip_ignores(data), **kwargs)
E       AssertionError: FILES DIFFER:
E      
/tmp/pytest-of-mockbuild/pytest-0/test_custom_convert_cache0/test_execute/test_custom_convert_cache.xml
E      
/tmp/pytest-of-mockbuild/pytest-0/test_custom_convert_cache0/test_execute/test_custom_convert_cache.obtained.xml
E       HTML DIFF:
/tmp/pytest-of-mockbuild/pytest-0/test_custom_convert_cache0/test_execute/test_custom_convert_cache.obtained.diff.html
E       --- 
E       +++ 
E       @@ -18,4 +18,4 @@
E                                <literal_block classes="output text_plain"
language="myst-ansi" xml:space="preserve">
E                                    <Figure size 640x480 with 1 Axes>
E                            <container mime_type="image/png">
E       -                        <image candidates="{'*':
'_build/jupyter_execute/a2e637020dfe58f670ba2c942d7a55e49ba48bed09312569ee15a84f5ac680cb.png'}"
uri="_build/jupyter_execute/a2e637020dfe58f670ba2c942d7a55e49ba48bed09312569ee15a84f5ac680cb.png">
E       +                        <image candidates="{'*':
'_build/jupyter_execute/d4af8d3724871916ca3dad388b7031ac3493074b53430101d6cea5d7c3924be9.png'}"
uri="_build/jupyter_execute/d4af8d3724871916ca3dad388b7031ac3493074b53430101d6cea5d7c3924be9.png">
/builddir/build/BUILD/MyST-NB-1.1.0/tests/conftest.py:286: AssertionError
----------------------------- Captured stderr call
-----------------------------
[IPKernelApp] WARNING | debugpy_stream undefined, debugging will not be enabled
=============================== warnings summary
===============================
../../../../usr/lib/python3.12/site-packages/jupyter_client/connect.py:22
  /usr/lib/python3.12/site-packages/jupyter_client/connect.py:22:
DeprecationWarning: Jupyter is migrating its paths to use standard platformdirs
  given by the platformdirs library.  To remove this warning and
  see the appropriate new directories, set the environment variable
  `JUPYTER_PLATFORM_DIRS=1` and then run `jupyter --paths`.
  The use of platformdirs will be the default in `jupyter_core` v6
    from jupyter_core.paths import jupyter_data_dir, jupyter_runtime_dir,
secure_write
tests/test_cli.py: 5 warnings
tests/test_codecell_file.py: 4 warnings
tests/test_docutils.py: 28 warnings
tests/test_eval.py: 2 warnings
tests/test_execute.py: 52 warnings
tests/test_glue.py: 2 warnings
tests/test_parser.py: 10 warnings
tests/test_render_outputs.py: 24 warnings
tests/test_text_based.py: 5 warnings
  /usr/lib/python3.12/site-packages/myst_parser/mdit_to_docutils/base.py:66:
DeprecationWarning: The frontend.OptionParser class will be replaced by a
subclass of argparse.ArgumentParser in Docutils 0.21 or later.
    settings = OptionParser(components=(parser_cls,)).get_default_values()
tests/test_cli.py: 345 warnings
tests/test_codecell_file.py: 276 warnings
tests/test_docutils.py: 1932 warnings
tests/test_eval.py: 138 warnings
tests/test_execute.py: 3588 warnings
tests/test_glue.py: 138 warnings
tests/test_parser.py: 690 warnings
tests/test_render_outputs.py: 1656 warnings
tests/test_text_based.py: 345 warnings
  /usr/lib64/python3.12/optparse.py:1000: DeprecationWarning: The
frontend.Option class will be removed in Docutils 0.21 or later.
    option = self.option_class(*args, **kwargs)
tests/test_codecell_file.py: 3 warnings
tests/test_execute.py: 23 warnings
tests/test_text_based.py: 3 warnings
  /usr/lib64/python3.12/site-packages/sqlalchemy/sql/schema.py:3585:
DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for
removal in a future version. Use timezone-aware objects to represent datetimes
in UTC: datetime.datetime.now(datetime.UTC).
    return util.wrap_callable(lambda ctx: fn(), fn)  # type: ignore
tests/test_execute.py::test_rebuild_cache
  /usr/lib/python3.12/site-packages/jupyter_cache/cache/db.py:371:
DeprecationWarning: datetime.datetime.utcnow() is deprecated and scheduled for
removal in a future version. Use timezone-aware objects to represent datetimes
in UTC: datetime.datetime.now(datetime.UTC).
    record.accessed = datetime.utcnow()
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info
============================
FAILED tests/test_execute.py::test_complex_outputs_unrun_cache -
AssertionErr...
FAILED tests/test_execute.py::test_complex_outputs_unrun_auto -
AssertionErro...
FAILED tests/test_execute.py::test_custom_convert_auto - AssertionError:
FILE...
FAILED tests/test_execute.py::test_custom_convert_cache - AssertionError:
FIL...
================= 4 failed, 76 passed, 9271 warnings in 47.99s
=================



Nothing will be approved until upstream clarify the license situation.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[?]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 3-Clause License", "*No copyright*
     MIT License". 166 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/python-myst-nb/review-
     python-myst-nb/licensecheck.txt
[?]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 34783 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Binary eggs must be removed in %prep
     Note: Cannot find any build in BUILD directory (--prebuilt option?)
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-myst-nb-1.1.0-1.fc41.noarch.rpm
          python-myst-nb-1.1.0-1.fc41.src.rpm
==============================================================================================================
rpmlint session starts
==============================================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpla7g628h')]
checks: 32, packages: 2

python-myst-nb.src: E: spelling-error ('Jupyter', 'Summary(en_US) Jupyter ->
Jupiter, Junketeer')
python3-myst-nb.noarch: E: spelling-error ('Jupyter', 'Summary(en_US) Jupyter
-> Jupiter, Junketeer')
======================================================================== 2
packages and 0 specfiles checked; 2 errors, 0 warnings, 18 filtered, 2 badness;
has taken 0.7 s
=========================================================================


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2278424

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202278424%23c2
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux