https://bugzilla.redhat.com/show_bug.cgi?id=2279076 Artem <ego.cordatus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ego.cordatus@gmai | |l.com) | --- Comment #5 from Artem <ego.cordatus@xxxxxxxxx> --- (In reply to Robert-André Mauchin 🐧 from comment #4) > > # Add Fedora PyKCS11 library location search path > > # https://github.com/LudovicRousseau/PyKCS11/pull/113 > > Patch: %{url}/pull/113.patch#/Add-Fedora-PyKCS11-library-location-search-path.patch > > This patch is problematic because it only checks /usr/lib64 and not /usr/lib > for 32 bits arches. Is Fedora still supporting 32 bit arches? Can we just add here "/usr/lib/pkcs11/pkcs11-spy.so" and "/usr/lib/pkcs11/libsofthsm2.so" for compatibility? > What are the issues with the tests? I didn’t have enough time to figure it out and fix the tests. It would be nice if experienced python folks could help with this to speed up the packing process. I've added note about test, they just simply not work in upstream defined way: E: NO TESTS RAN /usr/bin/python3 -m unittest discover pid=413 py312: FAIL code 5 All other issues fixed. New build: https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/07473689-python-pykcs11/python-pykcs11.spec https://download.copr.fedorainfracloud.org/results/atim/for-review/fedora-rawhide-x86_64/07473689-python-pykcs11/python-pykcs11-1.5.15-1.fc41.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2279076 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279076%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
