https://bugzilla.redhat.com/show_bug.cgi?id=2279341 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Notes (no change required): =========================== - It’s not necessary to number Source0; just Source: […] will do. Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Not an issue. While gcc is used indirectly, this is a Vala program and depending on vala suffices. - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/wingpanel-indicator-keyboard See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names OK: I note that this is a re-review for unretirement, https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming. ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Unversioned so-files -------------------- wingpanel-indicator-keyboard: /usr/lib64/wingpanel/libkeyboard.so These are indeed not in the ld path, and they are appropriately filtered from Provides generation. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v2.0 or later", "GNU Lesser General Public License v2.1 or later". 421 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2279341-wingpanel-indicator- keyboard/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. This is, however, no longer formally required: https://gitlab.com/fedora/legal/fedora-legal-docs/-/issues/64 If you wanted a license breakdown (and I do think it’s useful to have one), something like this should work: # The entire source is LGPL-2.1-or-later, except: # GPL-2.0-or-later: # data/KeyboardIcon.css [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/bn/LC_MESSAGES, /usr/share/locale/iu/LC_MESSAGES, /usr/share/locale/ts/LC_MESSAGES, /usr/share/locale/pa, /usr/share/locale/ny, /usr/share/locale/kw, /usr/share/locale/ve, /usr/share/locale/sr@latin/LC_MESSAGES, /usr/share/locale/gn, /usr/share/locale/sma/LC_MESSAGES, /usr/share/locale/ki, /usr/share/locale/sw/LC_MESSAGES, /usr/share/locale/bs, /usr/share/locale/li, /usr/share/locale/rue, /usr/share/locale/ro, /usr/share/locale/mr, /usr/share/locale/rm/LC_MESSAGES, /usr/share/locale/ko/LC_MESSAGES, /usr/share/locale/za, /usr/share/locale/mh/LC_MESSAGES, /usr/share/locale/se/LC_MESSAGES, /usr/share/locale/mt, /usr/share/locale/he, /usr/share/locale/ia/LC_MESSAGES, /usr/share/locale/ks, /usr/share/locale/id/LC_MESSAGES, /usr/share/locale/su, /usr/share/locale/sr, /usr/share/locale/cs, /usr/share/locale/eu, /usr/share/locale/fr_CA/LC_MESSAGES, /usr/share/locale/ne/LC_MESSAGES, /usr/share/locale/br, /usr/share, /usr/share/locale/hu/LC_MESSAGES, /usr/share/locale/zh_TW, /usr/share/locale/de/LC_MESSAGES, /usr/share/locale/af/LC_MESSAGES, /usr/share/locale/kn/LC_MESSAGES, /usr/share/locale/os/LC_MESSAGES, /usr/share/locale/ky/LC_MESSAGES, /usr/share/locale/en_CA/LC_MESSAGES, /usr/share/locale/ak/LC_MESSAGES, /usr/share/locale/hy/LC_MESSAGES, /usr/share/locale/tr/LC_MESSAGES, /usr/share/locale/yi, /usr/share/locale/mt/LC_MESSAGES, /usr/share/locale/ga, /usr/share/locale/yo/LC_MESSAGES, /usr/share/doc, /usr/share/locale/nl/LC_MESSAGES, /usr/share/locale/to/LC_MESSAGES, /usr/share/locale/ca, /usr/share/locale/dv, /usr/share/locale/pl, /usr/share/locale/nn/LC_MESSAGES, /usr/share/locale/kv/LC_MESSAGES, /usr/share/locale/sr/LC_MESSAGES, /usr/share/locale/bi, /usr/share/locale/to, /usr/share/locale/tr, /usr/share/locale, /usr/share/locale/af, /usr/share/locale/sg/LC_MESSAGES, /usr/share/locale/az/LC_MESSAGES, /usr/share/locale/da, /usr/share/locale/ug, /usr/share/locale/ho/LC_MESSAGES, /usr/share/locale/an/LC_MESSAGES, /usr/share/locale/ku/LC_MESSAGES, /usr/share/locale/ca@valencia, /usr/lib64, /usr/share/locale/ig, /usr/share/locale/ty, /usr/share/locale/ar, /usr/share/locale/co, /usr/share/locale/ga/LC_MESSAGES, /usr/share/locale/gn/LC_MESSAGES, /usr/share/locale/kk, /usr/share/locale/sma, /usr/share/locale/or, /usr/share/locale/av, /usr/share/locale/tg, /usr/share/locale/bi/LC_MESSAGES, /usr/share/locale/is/LC_MESSAGES, /usr/share/locale/ng/LC_MESSAGES, /usr/share/locale/ja/LC_MESSAGES, /usr/share/locale/si, /usr/share/locale/ch/LC_MESSAGES, /usr/lib, /usr/share/locale/ast/LC_MESSAGES, /usr/share/locale/fr, /usr/share/locale/fil, /usr/share/locale/sa, /usr/share/locale/dv/LC_MESSAGES, /usr/share/locale/st/LC_MESSAGES, /usr/share/locale/sm, /usr/share/locale/nb/LC_MESSAGES, /usr/share/locale/rw/LC_MESSAGES, /usr/share/locale/ks/LC_MESSAGES, /usr/share/locale/ki/LC_MESSAGES, /usr/share/locale/sk/LC_MESSAGES, /usr/share/locale/si/LC_MESSAGES, /usr/share/locale/da/LC_MESSAGES, /usr/share/locale/lo/LC_MESSAGES, /usr/share/locale/ro/LC_MESSAGES, /usr/share/locale/ff, /usr/share/locale/en_GB/LC_MESSAGES, /usr/share/locale/kk/LC_MESSAGES, /usr/share/locale/ti, /usr/share/locale/mk, /usr/share/locale/ug/LC_MESSAGES, /usr/share/locale/fy/LC_MESSAGES, /usr/share/locale/pi, /usr/share/locale/ka, /usr/share/locale/gl, /usr/share/locale/pa/LC_MESSAGES, /usr/share/locale/cu, /usr/share/locale/fy, /usr/share/locale/es/LC_MESSAGES, /usr/share/locale/bh/LC_MESSAGES, /usr/share/locale/dz, /usr/lib64/wingpanel, /usr/share/locale/ig/LC_MESSAGES, /usr/share/locale/ii, /usr/share/locale/kl, /usr/share/locale/no, /usr/share/locale/lv, /usr/share/locale/br/LC_MESSAGES, /usr/share/locale/ne, /usr/share/locale/as/LC_MESSAGES, /usr/share/locale/na/LC_MESSAGES, /usr/share/locale/kj/LC_MESSAGES, /usr/share/locale/ba, /usr/share/locale/ru, /usr/share/locale/bn, /usr/share/locale/sg, /usr/share/locale/io, /usr/share/locale/cr/LC_MESSAGES, /usr/share/locale/te, /usr/share/locale/ta/LC_MESSAGES, /usr/share/locale/pt, /usr/share/locale/ur/LC_MESSAGES, /usr/share/locale/az, /usr/share/locale/et/LC_MESSAGES, /usr/share/locale/fo/LC_MESSAGES, /usr/share/locale/my, /usr/share/locale/ba/LC_MESSAGES, /usr/share/locale/th, /usr/share/locale/ch, /usr/share/locale/ht/LC_MESSAGES, /usr/share/metainfo, /usr/share/locale/za/LC_MESSAGES, /usr, /usr/share/locale/lg/LC_MESSAGES, /usr/share/locale/sn, /usr/share/locale/so, /usr/share/locale/su/LC_MESSAGES, /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/oj, /usr/share/locale/ta, /usr/share/locale/bg/LC_MESSAGES, /usr/share/locale/tk/LC_MESSAGES, /usr/share/locale/te/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES, /usr/share/locale/lg, /usr/share/locale/ty/LC_MESSAGES, /usr/src, /usr/share/locale/lt/LC_MESSAGES, /usr/share/locale/de, /usr/share/locale/km, /usr/share/locale/zh_TW/LC_MESSAGES, /usr/share/locale/fil/LC_MESSAGES, /usr/share/locale/bo/LC_MESSAGES, /usr/share/locale/ce, /usr/share/locale/vo, /usr/share/locale/vi/LC_MESSAGES, /usr/share/locale/mk/LC_MESSAGES, /usr/share/locale/bm/LC_MESSAGES, /usr/share/locale/kl/LC_MESSAGES, /usr/share/locale/ja, /usr/share/locale/bs/LC_MESSAGES, /usr/share/locale/ky, /usr/share/locale/ab/LC_MESSAGES, /usr/share/locale/ka/LC_MESSAGES, /usr/share/locale/uz/LC_MESSAGES, /usr/share/locale/ckb, /usr/share/locale/szl/LC_MESSAGES, /usr/share/locale/vo/LC_MESSAGES, /usr/share/locale/qu, /usr/share/locale/tw, /usr/share/locale/fj/LC_MESSAGES, /usr/share/locale/ay, /usr/share/locale/ae/LC_MESSAGES, /usr/share/locale/st, /usr/share/locale/sw, /usr/share/locale/qu/LC_MESSAGES, /usr/share/locale/ab, /usr/share/locale/zh_CN, /usr/share/glib-2.0, /usr/share/locale/av/LC_MESSAGES, /usr/share/locale/ay/LC_MESSAGES, /usr/share/locale/oc, /usr/share/locale/bg, /usr/share/locale/ii/LC_MESSAGES, /usr/share/locale/ha, /usr/share/locale/cv, /usr/share/locale/nd, /usr/share/locale/oj/LC_MESSAGES, /usr/share/locale/yo, /usr/share/locale/fr_CA, /usr/share/locale/fr/LC_MESSAGES, /usr/share/locale/is, /usr/share/locale/it, /usr/share/locale/ia, /usr/share/locale/gv, /usr/share/locale/nr/LC_MESSAGES, /usr/share/locale/so/LC_MESSAGES, /usr/share/locale/yi/LC_MESSAGES, /usr/share/locale/gv/LC_MESSAGES, /usr/share/locale/mo, /usr/share/locale/ko, /usr/share/locale/la/LC_MESSAGES, /usr/share/locale/lt, /usr/share/locale/en_CA, /usr/share/locale/sl, /usr/share/locale/ar/LC_MESSAGES, /usr/share/locale/tl/LC_MESSAGES, /usr/share/locale/ce/LC_MESSAGES, /usr/share/locale/tg/LC_MESSAGES, /usr/share/locale/ms/LC_MESSAGES, /usr/share/locale/en_GB, /usr/share/locale/nn, /usr/share/locale/sq, /usr/share/locale/ts, /usr/share/locale/cs/LC_MESSAGES, /usr/share/locale/na, /usr/share/locale/ae, /usr/share/locale/sv, /usr/share/locale/hz, /usr/share/locale/lb, /usr/share/locale/co/LC_MESSAGES, /usr/share/locale/el/LC_MESSAGES, /usr/share/locale/sd, /usr/share/locale/ml/LC_MESSAGES, /usr/share/locale/wo, /usr/share/locale/lu/LC_MESSAGES, /usr/share/locale/cv/LC_MESSAGES, /usr/share/locale/hi, /usr/share/locale/ln/LC_MESSAGES, /usr/share/locale/pt_BR/LC_MESSAGES, /usr/share/locale/ng, /usr/share/locale/nv, /usr/share/locale/be/LC_MESSAGES, /usr/share/locale/bo, /usr/share/locale/gl/LC_MESSAGES, /usr/share/locale/kv, /usr/share/locale/fj, /usr/share/locale/an, /usr/share/locale/lv/LC_MESSAGES, /usr/share/locale/mi, /usr/share/locale/ru/LC_MESSAGES, /usr/share/locale/lo, /usr/share/locale/ho, /usr/share/locale/iu, /usr/share/locale/nd/LC_MESSAGES, /usr/share/locale/fa, /usr/share/locale/am, /usr/share/locale/szl, /usr/share/locale/aa, /usr/share/locale/el, /usr/share/locale/uk/LC_MESSAGES, /usr/share/locale/om, /usr/share/locale/cy, /usr/share/licenses, /usr/share/locale/mi/LC_MESSAGES, /usr/share/locale/he/LC_MESSAGES, /usr/share/locale/ik/LC_MESSAGES, /usr/share/locale/sc/LC_MESSAGES, /usr/share/locale/xh/LC_MESSAGES, /usr/share/locale/sm/LC_MESSAGES, /usr/share/locale/tn, /usr/share/locale/ca@valencia/LC_MESSAGES, /usr/share/locale/my/LC_MESSAGES, /usr/share/locale/hr/LC_MESSAGES, /usr/share/locale/tk, /usr/share/locale/ur, /usr/share/locale/zu/LC_MESSAGES, /usr/share/locale/kw/LC_MESSAGES, /usr/share/glib-2.0/schemas, /usr/share/locale/pt_BR, /usr/share/locale/hz/LC_MESSAGES, /usr/share/locale/sv/LC_MESSAGES, /usr/share/locale/sd/LC_MESSAGES, /usr/share/locale/ht, /usr/share/locale/lu, /usr/share/locale/jv/LC_MESSAGES, /usr/share/locale/ie/LC_MESSAGES, /usr/share/locale/eo/LC_MESSAGES, /usr/share/locale/gu/LC_MESSAGES, /usr/share/locale/kr, /usr/share/locale/zh_CN/LC_MESSAGES, /usr/share/locale/ps/LC_MESSAGES, /usr/share/locale/sq/LC_MESSAGES, /usr/share/locale/pi/LC_MESSAGES, /usr/share/locale/sr@latin, /usr/share/locale/es, /usr/share/locale/aa/LC_MESSAGES, /usr/share/locale/hy, /usr/share/locale/ln, /usr/share/locale/mg/LC_MESSAGES, /usr/share/locale/io/LC_MESSAGES, /usr/share/locale/wa/LC_MESSAGES, /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/xh, /usr/share/locale/cu/LC_MESSAGES, /usr/share/locale/jv, /usr/share/locale/tt, /usr/share/locale/fo, /usr/share/locale/mh, /usr/share/locale/eo, /usr/share/locale/as, /usr/share/locale/sa/LC_MESSAGES, /usr/share/locale/hu, /usr/share/locale/om/LC_MESSAGES, /usr/share/locale/rn, /usr/share/locale/sc, /usr/share/locale/eu/LC_MESSAGES, /usr/share/locale/be, /usr/share/locale/vi, /usr/share/locale/rw, /usr/share/locale/tt/LC_MESSAGES, /usr/share/locale/ha/LC_MESSAGES, /usr/share/locale/ss, /usr/share/locale/nb, /usr/share/locale/rn/LC_MESSAGES, /usr/share/locale/cy/LC_MESSAGES, /usr/share/locale/fa/LC_MESSAGES, /usr/share/locale/et, /usr/share/locale/bm, /usr/share/locale/kj, /usr/share/locale/zh, /usr/share/locale/sn/LC_MESSAGES, /usr/share/locale/pl/LC_MESSAGES, /usr/share/locale/ak, /usr/share/locale/fi, /usr/share/locale/it/LC_MESSAGES, /usr/share/locale/os, /usr/share/locale/la, /usr/share/locale/tn/LC_MESSAGES, /usr/share/locale/kg, /usr/share/locale/ms, /usr/src/debug, /usr/share/locale/gd/LC_MESSAGES, /usr/share/locale/zh_HK, /usr/share/locale/mn/LC_MESSAGES, /usr/share/locale/lb/LC_MESSAGES, /usr/share/locale/sl/LC_MESSAGES, /usr/share/locale/dz/LC_MESSAGES, /usr/share/locale/ast, /usr/share/locale/kg/LC_MESSAGES, /usr/share/locale/cr, /usr/share/locale/ve/LC_MESSAGES, /usr/share/locale/ee, /usr/share/locale/tl, /usr/share/locale/pt/LC_MESSAGES, /usr/share/locale/uz, /usr/share/locale/nl, /usr/share/locale/uk, /usr/share/locale/or/LC_MESSAGES, /usr/share/locale/li/LC_MESSAGES, /usr/share/locale/se, /usr/share/locale/ml, /usr/share/locale/zh_HK/LC_MESSAGES, /usr/share/locale/no/LC_MESSAGES, /usr/share/locale/ny/LC_MESSAGES, /usr/share/locale/mr/LC_MESSAGES, /usr/share/locale/nv/LC_MESSAGES, /usr/share/locale/gd, /usr/share/locale/zh/LC_MESSAGES, /usr/share/locale/hi/LC_MESSAGES, /usr/share/locale/kn, /usr/share/locale/km/LC_MESSAGES, /usr/share/locale/nr, /usr/share/locale/en_AU, /usr/share/locale/id, /usr/share/locale/sk, /usr/share/locale/en_AU/LC_MESSAGES, /usr/share/locale/zu, /usr/share/locale/ie, /usr/share/locale/wa, /usr/share/locale/mn, /usr/share/locale/am/LC_MESSAGES, /usr/share/locale/th/LC_MESSAGES, /usr/share/locale/wo/LC_MESSAGES, /usr/share/locale/mg, /usr/share/locale/ku, /usr/share/locale/rm, /usr/share/locale/ps, /usr/share/locale/ee/LC_MESSAGES, /usr/share/locale/ti/LC_MESSAGES, /usr/share/locale/tw/LC_MESSAGES, /usr/share/locale/ik, /usr/share/locale/ss/LC_MESSAGES, /usr/share/locale/ff/LC_MESSAGES, /usr/share/locale/kr/LC_MESSAGES, /usr/share/locale/hr, /usr/share/locale/gu, /usr/share/locale/fi/LC_MESSAGES, /usr/share/locale/bh, /usr/share/locale/oc/LC_MESSAGES, /usr/share/locale/ca/LC_MESSAGES Spurious diagnostics (fedora-review bug). The wingpanel dependency provides %{_libdir}/wingpanel. Regarding /usr/share/locale/mo and /usr/share/locale/mo/LC_MESSAGES, this should be fixed in the filesystem package, as discussed in https://bugzilla.redhat.com/show_bug.cgi?id=2279336. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/bn/LC_MESSAGES, /usr/share/locale/iu/LC_MESSAGES, /usr/share/locale/ts/LC_MESSAGES, /usr/share/locale/pa, /usr/share/locale/ny, /usr/share/locale/kw, /usr/share/locale/ve, /usr/share/locale/sr@latin/LC_MESSAGES, /usr/share/locale/gn, /usr/share/locale/sma/LC_MESSAGES, /usr/share/locale/ki, /usr/share/locale/sw/LC_MESSAGES, /usr/share/locale/bs, /usr/share/locale/li, /usr/share/locale/rue, /usr/share/locale/ro, /usr/share/locale/mr, /usr/share/locale/rm/LC_MESSAGES, /usr/share/locale/ko/LC_MESSAGES, /usr/share/locale/za, /usr/share/locale/mh/LC_MESSAGES, /usr/share/locale/se/LC_MESSAGES, /usr/share/locale/mt, /usr/share/locale/he, /usr/share/locale/ia/LC_MESSAGES, /usr/share/locale/ks, /usr/share/locale/id/LC_MESSAGES, /usr/share/locale/su, /usr/share/locale/sr, /usr/share/locale/cs, /usr/share/locale/eu, /usr/share/locale/fr_CA/LC_MESSAGES, /usr/share/locale/ne/LC_MESSAGES, /usr/share/locale/br, /usr/share, /usr/share/locale/hu/LC_MESSAGES, /usr/share/locale/zh_TW, /usr/share/locale/de/LC_MESSAGES, /usr/share/locale/af/LC_MESSAGES, /usr/share/locale/kn/LC_MESSAGES, /usr/share/locale/os/LC_MESSAGES, /usr/share/locale/ky/LC_MESSAGES, /usr/share/locale/en_CA/LC_MESSAGES, /usr/share/locale/ak/LC_MESSAGES, /usr/share/locale/hy/LC_MESSAGES, /usr/share/locale/tr/LC_MESSAGES, /usr/share/locale/yi, /usr/share/locale/mt/LC_MESSAGES, /usr/share/locale/ga, /usr/share/locale/yo/LC_MESSAGES, /usr/share/doc, /usr/share/locale/nl/LC_MESSAGES, /usr/share/locale/to/LC_MESSAGES, /usr/share/locale/ca, /usr/share/locale/dv, /usr/share/locale/pl, /usr/share/locale/nn/LC_MESSAGES, /usr/share/locale/kv/LC_MESSAGES, /usr/share/locale/sr/LC_MESSAGES, /usr/share/locale/bi, /usr/share/locale/to, /usr/share/locale/tr, /usr/share/locale, /usr/share/locale/af, /usr/share/locale/sg/LC_MESSAGES, /usr/share/locale/az/LC_MESSAGES, /usr/share/locale/da, /usr/share/locale/ug, /usr/share/locale/ho/LC_MESSAGES, /usr/share/locale/an/LC_MESSAGES, /usr/share/locale/ku/LC_MESSAGES, /usr/share/locale/ca@valencia, /usr/lib64, /usr/share/locale/ig, /usr/share/locale/ty, /usr/share/locale/ar, /usr/share/locale/co, /usr/share/locale/ga/LC_MESSAGES, /usr/share/locale/gn/LC_MESSAGES, /usr/share/locale/kk, /usr/share/locale/sma, /usr/share/locale/or, /usr/share/locale/av, /usr/share/locale/tg, /usr/share/locale/bi/LC_MESSAGES, /usr/share/locale/is/LC_MESSAGES, /usr/share/locale/ng/LC_MESSAGES, /usr/share/locale/ja/LC_MESSAGES, /usr/share/locale/si, /usr/share/locale/ch/LC_MESSAGES, /usr/lib, /usr/share/locale/ast/LC_MESSAGES, /usr/share/locale/fr, /usr/share/locale/fil, /usr/share/locale/sa, /usr/share/locale/dv/LC_MESSAGES, /usr/share/locale/st/LC_MESSAGES, /usr/share/locale/sm, /usr/share/locale/nb/LC_MESSAGES, /usr/share/locale/rw/LC_MESSAGES, /usr/share/locale/ks/LC_MESSAGES, /usr/share/locale/ki/LC_MESSAGES, /usr/share/locale/sk/LC_MESSAGES, /usr/share/locale/si/LC_MESSAGES, /usr/share/locale/da/LC_MESSAGES, /usr/share/locale/lo/LC_MESSAGES, /usr/share/locale/ro/LC_MESSAGES, /usr/share/locale/ff, /usr/share/locale/en_GB/LC_MESSAGES, /usr/share/locale/kk/LC_MESSAGES, /usr/share/locale/ti, /usr/share/locale/mk, /usr/share/locale/ug/LC_MESSAGES, /usr/share/locale/fy/LC_MESSAGES, /usr/share/locale/pi, /usr/share/locale/ka, /usr/share/locale/gl, /usr/share/locale/pa/LC_MESSAGES, /usr/share/locale/cu, /usr/share/locale/fy, /usr/share/locale/es/LC_MESSAGES, /usr/share/locale/bh/LC_MESSAGES, /usr/share/locale/dz, /usr/lib64/wingpanel, /usr/share/locale/ig/LC_MESSAGES, /usr/share/locale/ii, /usr/share/locale/kl, /usr/share/locale/no, /usr/share/locale/lv, /usr/share/locale/br/LC_MESSAGES, /usr/share/locale/ne, /usr/share/locale/as/LC_MESSAGES, /usr/share/locale/na/LC_MESSAGES, /usr/share/locale/kj/LC_MESSAGES, /usr/share/locale/ba, /usr/share/locale/ru, /usr/share/locale/bn, /usr/share/locale/sg, /usr/share/locale/io, /usr/share/locale/cr/LC_MESSAGES, /usr/share/locale/te, /usr/share/locale/ta/LC_MESSAGES, /usr/share/locale/pt, /usr/share/locale/ur/LC_MESSAGES, /usr/share/locale/az, /usr/share/locale/et/LC_MESSAGES, /usr/share/locale/fo/LC_MESSAGES, /usr/share/locale/my, /usr/share/locale/ba/LC_MESSAGES, /usr/share/locale/th, /usr/share/locale/ch, /usr/share/locale/ht/LC_MESSAGES, /usr/share/metainfo, /usr/share/locale/za/LC_MESSAGES, /usr, /usr/share/locale/lg/LC_MESSAGES, /usr/share/locale/sn, /usr/share/locale/so, /usr/share/locale/su/LC_MESSAGES, /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/oj, /usr/share/locale/ta, /usr/share/locale/bg/LC_MESSAGES, /usr/share/locale/tk/LC_MESSAGES, /usr/share/locale/te/LC_MESSAGES, /usr/share/locale/ckb/LC_MESSAGES, /usr/share/locale/lg, /usr/share/locale/ty/LC_MESSAGES, /usr/src, /usr/share/locale/lt/LC_MESSAGES, /usr/share/locale/de, /usr/share/locale/km, /usr/share/locale/zh_TW/LC_MESSAGES, /usr/share/locale/fil/LC_MESSAGES, /usr/share/locale/bo/LC_MESSAGES, /usr/share/locale/ce, /usr/share/locale/vo, /usr/share/locale/vi/LC_MESSAGES, /usr/share/locale/mk/LC_MESSAGES, /usr/share/locale/bm/LC_MESSAGES, /usr/share/locale/kl/LC_MESSAGES, /usr/share/locale/ja, /usr/share/locale/bs/LC_MESSAGES, /usr/share/locale/ky, /usr/share/locale/ab/LC_MESSAGES, /usr/share/locale/ka/LC_MESSAGES, /usr/share/locale/uz/LC_MESSAGES, /usr/share/locale/ckb, /usr/share/locale/szl/LC_MESSAGES, /usr/share/locale/vo/LC_MESSAGES, /usr/share/locale/qu, /usr/share/locale/tw, /usr/share/locale/fj/LC_MESSAGES, /usr/share/locale/ay, /usr/share/locale/ae/LC_MESSAGES, /usr/share/locale/st, /usr/share/locale/sw, /usr/share/locale/qu/LC_MESSAGES, /usr/share/locale/ab, /usr/share/locale/zh_CN, /usr/share/glib-2.0, /usr/share/locale/av/LC_MESSAGES, /usr/share/locale/ay/LC_MESSAGES, /usr/share/locale/oc, /usr/share/locale/bg, /usr/share/locale/ii/LC_MESSAGES, /usr/share/locale/ha, /usr/share/locale/cv, /usr/share/locale/nd, /usr/share/locale/oj/LC_MESSAGES, /usr/share/locale/yo, /usr/share/locale/fr_CA, /usr/share/locale/fr/LC_MESSAGES, /usr/share/locale/is, /usr/share/locale/it, /usr/share/locale/ia, /usr/share/locale/gv, /usr/share/locale/nr/LC_MESSAGES, /usr/share/locale/so/LC_MESSAGES, /usr/share/locale/yi/LC_MESSAGES, /usr/share/locale/gv/LC_MESSAGES, /usr/share/locale/mo, /usr/share/locale/ko, /usr/share/locale/la/LC_MESSAGES, /usr/share/locale/lt, /usr/share/locale/en_CA, /usr/share/locale/sl, /usr/share/locale/ar/LC_MESSAGES, /usr/share/locale/tl/LC_MESSAGES, /usr/share/locale/ce/LC_MESSAGES, /usr/share/locale/tg/LC_MESSAGES, /usr/share/locale/ms/LC_MESSAGES, /usr/share/locale/en_GB, /usr/share/locale/nn, /usr/share/locale/sq, /usr/share/locale/ts, /usr/share/locale/cs/LC_MESSAGES, /usr/share/locale/na, /usr/share/locale/ae, /usr/share/locale/sv, /usr/share/locale/hz, /usr/share/locale/lb, /usr/share/locale/co/LC_MESSAGES, /usr/share/locale/el/LC_MESSAGES, /usr/share/locale/sd, /usr/share/locale/ml/LC_MESSAGES, /usr/share/locale/wo, /usr/share/locale/lu/LC_MESSAGES, /usr/share/locale/cv/LC_MESSAGES, /usr/share/locale/hi, /usr/share/locale/ln/LC_MESSAGES, /usr/share/locale/pt_BR/LC_MESSAGES, /usr/share/locale/ng, /usr/share/locale/nv, /usr/share/locale/be/LC_MESSAGES, /usr/share/locale/bo, /usr/share/locale/gl/LC_MESSAGES, /usr/share/locale/kv, /usr/share/locale/fj, /usr/share/locale/an, /usr/share/locale/lv/LC_MESSAGES, /usr/share/locale/mi, /usr/share/locale/ru/LC_MESSAGES, /usr/share/locale/lo, /usr/share/locale/ho, /usr/share/locale/iu, /usr/share/locale/nd/LC_MESSAGES, /usr/share/locale/fa, /usr/share/locale/am, /usr/share/locale/szl, /usr/share/locale/aa, /usr/share/locale/el, /usr/share/locale/uk/LC_MESSAGES, /usr/share/locale/om, /usr/share/locale/cy, /usr/share/licenses, /usr/share/locale/mi/LC_MESSAGES, /usr/share/locale/he/LC_MESSAGES, /usr/share/locale/ik/LC_MESSAGES, /usr/share/locale/sc/LC_MESSAGES, /usr/share/locale/xh/LC_MESSAGES, /usr/share/locale/sm/LC_MESSAGES, /usr/share/locale/tn, /usr/share/locale/ca@valencia/LC_MESSAGES, /usr/share/locale/my/LC_MESSAGES, /usr/share/locale/hr/LC_MESSAGES, /usr/share/locale/tk, /usr/share/locale/ur, /usr/share/locale/zu/LC_MESSAGES, /usr/share/locale/kw/LC_MESSAGES, /usr/share/glib-2.0/schemas, /usr/share/locale/pt_BR, /usr/share/locale/hz/LC_MESSAGES, /usr/share/locale/sv/LC_MESSAGES, /usr/share/locale/sd/LC_MESSAGES, /usr/share/locale/ht, /usr/share/locale/lu, /usr/share/locale/jv/LC_MESSAGES, /usr/share/locale/ie/LC_MESSAGES, /usr/share/locale/eo/LC_MESSAGES, /usr/share/locale/gu/LC_MESSAGES, /usr/share/locale/kr, /usr/share/locale/zh_CN/LC_MESSAGES, /usr/share/locale/ps/LC_MESSAGES, /usr/share/locale/sq/LC_MESSAGES, /usr/share/locale/pi/LC_MESSAGES, /usr/share/locale/sr@latin, /usr/share/locale/es, /usr/share/locale/aa/LC_MESSAGES, /usr/share/locale/hy, /usr/share/locale/ln, /usr/share/locale/mg/LC_MESSAGES, /usr/share/locale/io/LC_MESSAGES, /usr/share/locale/wa/LC_MESSAGES, /usr/share/locale/rue/LC_MESSAGES, /usr/share/locale/xh, /usr/share/locale/cu/LC_MESSAGES, /usr/share/locale/jv, /usr/share/locale/tt, /usr/share/locale/fo, /usr/share/locale/mh, /usr/share/locale/eo, /usr/share/locale/as, /usr/share/locale/sa/LC_MESSAGES, /usr/share/locale/hu, /usr/share/locale/om/LC_MESSAGES, /usr/share/locale/rn, /usr/share/locale/sc, /usr/share/locale/eu/LC_MESSAGES, /usr/share/locale/be, /usr/share/locale/vi, /usr/share/locale/rw, /usr/share/locale/tt/LC_MESSAGES, /usr/share/locale/ha/LC_MESSAGES, /usr/share/locale/ss, /usr/share/locale/nb, /usr/share/locale/rn/LC_MESSAGES, /usr/share/locale/cy/LC_MESSAGES, /usr/share/locale/fa/LC_MESSAGES, /usr/share/locale/et, /usr/share/locale/bm, /usr/share/locale/kj, /usr/share/locale/zh, /usr/share/locale/sn/LC_MESSAGES, /usr/share/locale/pl/LC_MESSAGES, /usr/share/locale/ak, /usr/share/locale/fi, /usr/share/locale/it/LC_MESSAGES, /usr/share/locale/os, /usr/share/locale/la, /usr/share/locale/tn/LC_MESSAGES, /usr/share/locale/kg, /usr/share/locale/ms, /usr/src/debug, /usr/share/locale/gd/LC_MESSAGES, /usr/share/locale/zh_HK, /usr/share/locale/mn/LC_MESSAGES, /usr/share/locale/lb/LC_MESSAGES, /usr/share/locale/sl/LC_MESSAGES, /usr/share/locale/dz/LC_MESSAGES, /usr/share/locale/ast, /usr/share/locale/kg/LC_MESSAGES, /usr/share/locale/cr, /usr/share/locale/ve/LC_MESSAGES, /usr/share/locale/ee, /usr/share/locale/tl, /usr/share/locale/pt/LC_MESSAGES, /usr/share/locale/uz, /usr/share/locale/nl, /usr/share/locale/uk, /usr/share/locale/or/LC_MESSAGES, /usr/share/locale/li/LC_MESSAGES, /usr/share/locale/se, /usr/share/locale/ml, /usr/share/locale/zh_HK/LC_MESSAGES, /usr/share/locale/no/LC_MESSAGES, /usr/share/locale/ny/LC_MESSAGES, /usr/share/locale/mr/LC_MESSAGES, /usr/share/locale/nv/LC_MESSAGES, /usr/share/locale/gd, /usr/share/locale/zh/LC_MESSAGES, /usr/share/locale/hi/LC_MESSAGES, /usr/share/locale/kn, /usr/share/locale/km/LC_MESSAGES, /usr/share/locale/nr, /usr/share/locale/en_AU, /usr/share/locale/id, /usr/share/locale/sk, /usr/share/locale/en_AU/LC_MESSAGES, /usr/share/locale/zu, /usr/share/locale/ie, /usr/share/locale/wa, /usr/share/locale/mn, /usr/share/locale/am/LC_MESSAGES, /usr/share/locale/th/LC_MESSAGES, /usr/share/locale/wo/LC_MESSAGES, /usr/share/locale/mg, /usr/share/locale/ku, /usr/share/locale/rm, /usr/share/locale/ps, /usr/share/locale/ee/LC_MESSAGES, /usr/share/locale/ti/LC_MESSAGES, /usr/share/locale/tw/LC_MESSAGES, /usr/share/locale/ik, /usr/share/locale/ss/LC_MESSAGES, /usr/share/locale/ff/LC_MESSAGES, /usr/share/locale/kr/LC_MESSAGES, /usr/share/locale/hr, /usr/share/locale/gu, /usr/share/locale/fi/LC_MESSAGES, /usr/share/locale/bh, /usr/share/locale/oc/LC_MESSAGES, /usr/share/locale/ca/LC_MESSAGES Spurious diagnostics (fedora-review bug). The wingpanel dependency provides %{_libdir}/wingpanel. Regarding /usr/share/locale/mo and /usr/share/locale/mo/LC_MESSAGES, this should be fixed in the filesystem package, as discussed in https://bugzilla.redhat.com/show_bug.cgi?id=2279336. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). Duplicate localization files are not worth hardlinking. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 639 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. I assume that the package will be tested interactively. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=117346351 [x]: %check is present and all tests pass. However, upstream provides no tests; %check contains the prescribed AppStream metadata validation. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: wingpanel-indicator-keyboard-2.4.1-1.fc41.x86_64.rpm wingpanel-indicator-keyboard-debuginfo-2.4.1-1.fc41.x86_64.rpm wingpanel-indicator-keyboard-debugsource-2.4.1-1.fc41.x86_64.rpm wingpanel-indicator-keyboard-2.4.1-1.fc41.src.rpm =========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbe_c437g')] checks: 32, packages: 4 wingpanel-indicator-keyboard.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/keyboard-indicator.mo wingpanel-indicator-keyboard.x86_64: W: files-duplicate /usr/share/locale/zu/LC_MESSAGES/keyboard-indicator.mo /usr/share/locale/aa/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/ab/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/ae/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/ak/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/an/LC_MESSAGES/keyboard-indicator.mo:(and 112 more) wingpanel-indicator-keyboard.x86_64: W: files-duplicate /usr/share/locale/zh_HK/LC_MESSAGES/keyboard-indicator.mo /usr/share/locale/af/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/am/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/ast/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/be/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/bn/LC_MESSAGES/keyboard-indicator.mo:(and 16 more) wingpanel-indicator-keyboard.x86_64: W: files-duplicate /usr/share/locale/no/LC_MESSAGES/keyboard-indicator.mo /usr/share/locale/fo/LC_MESSAGES/keyboard-indicator.mo ===================================================== 4 packages and 0 specfiles checked; 1 errors, 3 warnings, 17 filtered, 1 badness; has taken 0.7 s ===================================================== Rpmlint (debuginfo) ------------------- Checking: wingpanel-indicator-keyboard-debuginfo-2.4.1-1.fc41.x86_64.rpm =========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpr3_6so2f')] checks: 32, packages: 1 ====================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.1 s ===================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 wingpanel-indicator-keyboard.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/keyboard-indicator.mo wingpanel-indicator-keyboard.x86_64: W: files-duplicate /usr/share/locale/zu/LC_MESSAGES/keyboard-indicator.mo /usr/share/locale/aa/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/ab/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/ae/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/ak/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/an/LC_MESSAGES/keyboard-indicator.mo:(and 112 more) wingpanel-indicator-keyboard.x86_64: W: files-duplicate /usr/share/locale/zh_HK/LC_MESSAGES/keyboard-indicator.mo /usr/share/locale/af/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/am/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/ast/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/be/LC_MESSAGES/keyboard-indicator.mo:/usr/share/locale/bn/LC_MESSAGES/keyboard-indicator.mo:(and 16 more) wingpanel-indicator-keyboard.x86_64: W: files-duplicate /usr/share/locale/no/LC_MESSAGES/keyboard-indicator.mo /usr/share/locale/fo/LC_MESSAGES/keyboard-indicator.mo 3 packages and 0 specfiles checked; 1 errors, 3 warnings, 14 filtered, 1 badness; has taken 0.4 s Unversioned so-files -------------------- wingpanel-indicator-keyboard: /usr/lib64/wingpanel/libkeyboard.so Source checksums ---------------- https://github.com/elementary/wingpanel-indicator-keyboard/archive/2.4.1/wingpanel-indicator-keyboard-2.4.1.tar.gz : CHECKSUM(SHA256) this package : 7eba1ecf16b539fb0c5631a91d36310cd652d830c48efa6f5e7f11c9fb307566 CHECKSUM(SHA256) upstream package : 7eba1ecf16b539fb0c5631a91d36310cd652d830c48efa6f5e7f11c9fb307566 Requires -------- wingpanel-indicator-keyboard (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgdk-3.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgranite.so.6()(64bit) libgtk-3.so.0()(64bit) libibus-1.0.so.5()(64bit) libwingpanel.so.3()(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) rtld(GNU_HASH) wingpanel(x86-64) wingpanel-indicator-keyboard-debuginfo (rpmlib, GLIBC filtered): wingpanel-indicator-keyboard-debugsource (rpmlib, GLIBC filtered): Provides -------- wingpanel-indicator-keyboard: metainfo() metainfo(io.elementary.wingpanel.keyboard.appdata.xml) wingpanel-indicator-keyboard wingpanel-indicator-keyboard(x86-64) wingpanel-indicator-keyboard-debuginfo: debuginfo(build-id) libkeyboard.so-2.4.1-1.fc41.x86_64.debug()(64bit) wingpanel-indicator-keyboard-debuginfo wingpanel-indicator-keyboard-debuginfo(x86-64) wingpanel-indicator-keyboard-debugsource: wingpanel-indicator-keyboard-debugsource wingpanel-indicator-keyboard-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2279341 --mock-options=--dnf Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Perl, R, PHP, fonts, Java, Ocaml, Haskell, SugarActivity, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279341 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279341%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
