[Bug 2281965] Review Request: rust-tokio-tar - Rust implementation of an async TAR file reader and writer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2281965

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx



--- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
I took a quick look at the test failures.

On i686, it looks like it's failing to allocate 1.6 GB in the doctest that adds
the current directory (".") into a tar archive.
This likely includes the "target" directory, so any compiled artifacts
generated during %cargo_build and %cargo_test.
This is likely working *most of the time*, but it's maybe not a good idea in
general.

see https://github.com/vorot93/tokio-tar/blob/master/src/builder.rs#L400

On s390x, I can't really tell what's going wrong. The error message isn't that
helpful because the test just "assert!(entries.next().await.is_none()" instead
of using "assert_eq!(entries.next().await, None)", which would print the value
that is "not none" in the error message instead of just saying "I wanted a
true, but I got a false! FAIL"). Is the failure persistent? It might just have
been a fluke.

see https://github.com/vorot93/tokio-tar/blob/master/tests/all.rs#L1103


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2281965

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202281965%23c4
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux