https://bugzilla.redhat.com/show_bug.cgi?id=2276535 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx CC| |zebob.m@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- > Release: 6%{?dist} You could use %autorelease > License: GPLv2 Please use SPDX format > Source0: %url/archive/V%{version}/%{name}-%{version}.tar.gz Drop the 0 after Source nowadays > Patch0: redfish-finder-python3.patch Document the patch, what is it for? Is it upstreamed? If yes link to it. > Requires: python3 NetworkManager dmidecode Split this one per line please. > BuildRequires: systemd Unless rare can, you generally just need: BuildRequires: systemd-rpm-macros > %{?systemd_requires} This is rarely needed too The %{?systemd_requires} macro is a shortcut to require systemd for the %pre, %post, and %postun scriptlets. Note that those dependencies are not required for the %systemd_{post,preun,postun_with_restart,user_post,user_preun} macros listed above. > %changelog You could use %autochangelog here too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2276535 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276535%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
