https://bugzilla.redhat.com/show_bug.cgi?id=2280325 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Good catch! Looking at the source code for both this crate and the Camellia implementation in Botan, the Rust code here looks quite different from the C++ code from botan, other than the constants from the definition of the cipher and the implementation of the math for the cipher itself. Everything else is different - for example, it uses Rust metaprogramming techniques that aren't even available in C++ to generate concrete implementations for Camellia128, Camellia192, and Camellia256 at compile-time. If src/camellia.rs were 1:1 transpiled from C++ to Rust with a tool like like c2rust, an argument could be made that the original license still applies, but in this case, the implementation (other than the definition of the cipher itself, which Botan didn't invent either) is sufficiently different that the botan license doesn't apply - at least in my opinion. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2280325 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202280325%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
