https://bugzilla.redhat.com/show_bug.cgi?id=2271219 --- Comment #7 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks for the update. Mostly seems ok. Comments: a) Spec file is: https://hobbes1069.fedorapeople.org/sioclient-cpp.spec b) Please remove the binary sio_test by adding: rm test/sio_test in the %prep section c) Please also add chmod -x ./LICENSE in the %prep section d) To enable tests please add BuildRequires: catch2-devel then change %cmake -DUSE_SUBMODULES=OFF -DBUILD_SHARED_LIBS=ON to %cmake -DBUILD_UNIT_TESTS=ON -DUSE_SUBMODULES=OFF -DBUILD_SHARED_LIBS=ON then after the %install section add: %check %ctest The source files also need a modification indicated in the patch below: diff -ruN socket.io-client-cpp-3.1.0/test/CMakeLists.txt socket.io-client-cpp-3.1.0-mod/test/CMakeLists.txt --- socket.io-client-cpp-3.1.0/test/CMakeLists.txt 2021-10-12 08:24:29.000000000 +0000 +++ socket.io-client-cpp-3.1.0-mod/test/CMakeLists.txt 2024-05-18 16:14:07.013475270 +0000 @@ -1,9 +1,16 @@ +find_package(Catch2 CONFIG REQUIRED) + add_executable(sio_test sio_test.cpp) set_property(TARGET sio_test PROPERTY CXX_STANDARD 11) set_property(TARGET sio_test PROPERTY CXX_STANDARD_REQUIRED ON) -target_link_libraries(sio_test sioclient) -target_include_directories(sio_test PRIVATE - "${CMAKE_CURRENT_SOURCE_DIR}/../lib/catch/include" - "${CMAKE_CURRENT_SOURCE_DIR}/../src" +target_link_libraries(sio_test + PRIVATE + sioclient ) +target_include_directories(sio_test + PRIVATE + ${CATCH2_INCLUDE_DIR} + "${CMAKE_CURRENT_SOURCE_DIR}/../src" +) + add_test(sioclient_test sio_test) Binary files socket.io-client-cpp-3.1.0/test/sio_test and socket.io-client-cpp-3.1.0-mod/test/sio_test differ diff -ruN socket.io-client-cpp-3.1.0/test/sio_test.cpp socket.io-client-cpp-3.1.0-mod/test/sio_test.cpp --- socket.io-client-cpp-3.1.0/test/sio_test.cpp 2021-10-12 08:24:29.000000000 +0000 +++ socket.io-client-cpp-3.1.0-mod/test/sio_test.cpp 2024-05-18 16:16:40.048805932 +0000 @@ -11,7 +11,7 @@ #include <thread> #define CATCH_CONFIG_MAIN // This tells Catch to provide a main() - only do this in one cpp file -#include "catch.hpp" +#include <catch2/catch.hpp> #ifndef _WIN32 #include "json.hpp" //nlohmann::json cannot build in MSVC -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2271219 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202271219%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
