https://bugzilla.redhat.com/show_bug.cgi?id=2276462 --- Comment #4 from wojnilowicz <lukasz.wojnilowicz@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #3) > There's a few small issues: > > - Don't override the %description. The generated one is fine. Done. > - Don't "rm" the license files for the bundled thread_local code. Done. > - Don't remove the "%license" file entries for the bundled thread_local code. Done. > - Add "Provides: bundled(crate(thread_local)) = <version>" to the "-devel" > subpackage. Done. > I'm not sure why the thread_local code is bundled at all, it doesn't seem to > be documented. > But it *is* bundled, and it needs to be specified in RPM metadata. > > Maybe you can find out which version of the thread_local crate is bundled. Indeed. Here are my findings: 1) thread_local imported (on 2020-10-28) with this commit https://github.com/SergioBenitez/state/commit/9a3f70afb8cf5a4501622066fca1b37170c4a616 2) not synchronized with thread_local afterwards 3) thread_local 1.0.1 on crates.io is from 2020-01-11, so it's probable this was imported 4) thread_local 1.1.0 on crates.io is from 2021-01-07, so it's impossible this was imported 5) thread_id.rs and unreachable.rs from "state" matches 100% with "thread_local" 1.1.0 6) mod.rs (9,2 KB) from "state" is a heavily modified version of lib.rs (18,8 KB) from "thread_local" It seems that "state" forked "thread_local". Are you sure that we should add "Provides: bundled(crate(thread_local)) = 1.0.1" then? Anyway, I've updated my spec and src.rpm file in the first post. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2276462 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202276462%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
