https://bugzilla.redhat.com/show_bug.cgi?id=2279853 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #11 from Fabio Valentini <decathorpe@xxxxxxxxx> --- When I try to re-create your spec file with "rust2rpm -p", I'm getting a slightly different result. Please don't modify output from rust2rpm without good reason (i.e. if it's wrong), and *if* rust2rpm does something wrong, please report it as a bug. ... -# Upstream license specification: MIT/Apache-2.0 -License: MIT OR Apache-2.0 +License: (MIT OR Apache-2.0) AND Unicode-DFS-2016 URL: https://crates.io/crates/unicode-properties Source: %{crates_source} -# # * https://github.com/unicode-rs/unicode-properties/pull/6 -# # * add missing Unicode license terms to crate metadata -Patch10: unicode-properties-fix-metadata.diff +# Manually created patch for downstream crate metadata changes +# * add missing Unicode license terms to crate metadata +# * https://github.com/unicode-rs/unicode-properties/pull/6 +Patch: unicode-properties-fix-metadata.diff ... Making modifications to lines generated by rust2rpm will just cause more work on future updates. Other than that, I think this package looks acceptable: The crate contains only code generated *from* Unicode data, but not the unicode data *itself*, which makes the licensing situation clear. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2279853 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279853%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
