https://bugzilla.redhat.com/show_bug.cgi?id=2280598 --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This package looks good overall. I found only a few minor details that should be followed up on before proceeding. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - The package description has some overly long lines: python-astropy-iers-data.src: E: description-line-too-long This package provides IERS Earth Rotation and Leap Second tables for the astropy.utils.iers package. python-astropy-iers-data.src: E: description-line-too-long Note: This package is not currently meant to be used directly by users, and only meant to be used from the core Astropy package. python3-astropy-iers-data.noarch: E: description-line-too-long This package provides IERS Earth Rotation and Leap Second tables for the astropy.utils.iers package. python3-astropy-iers-data.noarch: E: description-line-too-long Note: This package is not currently meant to be used directly by users, and only meant to be used from the core Astropy package. Please wrap the description to 80 characters or less. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description Also, the blank lines after * Bulletin A (IERS_A) is updated weekly and has historical data and * Bulletin B (IERS_B) is updated monthly and has data from 1962 up to split up those bulleted paragraphs, and look unintentional. Suggested format for the given description: %global _description %{expand: This package provides IERS Earth Rotation and Leap Second tables for the astropy.utils.iers package. There the following IERS data products are included: * Bulletin A (IERS_A) is updated weekly and has historical data starting from 1973 and predictive data for 1 year into the future. It contains Earth orientation parameters x/y pole, UT1-UTC and their errors at daily intervals. * Bulletin B (IERS_B) is updated monthly and has data from 1962 up to the time when it is generated. This file contains Earth’s orientation in the IERS Reference System including Universal Time, coordinates of the terrestrial pole, and celestial pole offsets. The package also provides leap second data. Note: This package is not currently meant to be used directly by users, and only meant to be used from the core Astropy package.} - The zero-argument form of %{pypi_source} is deprecated. Please change Source0: %{pypi_source} to Source0: %{pypi_source %{srcname}} - Since you are relying on the license file being properly marked in the .dist-info directory (which it is!), you should change %pyproject_save_files astropy_iers_data to %pyproject_save_files -l astropy_iers_data so that the build fails if the license fail is absent in a future update. ===== Notes (no change required) ===== - It’s no longer necessary to number the sources and patches in most cases; you could write Source: and Patch: instead of Source0: and Patch0:. It’s still permissible to number them, though. - You are probably already aware that, in order for this package to be useful, you are going to need to provide updates very promptly when upstream releases them, and you should expect them to be pretty frequent. This might be a good use case for Packit even if you aren’t convinced of its value for your other packages. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD 3-Clause License", "Unknown or generated". 16 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/review-python-astropy-iers- data/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.12, /usr/lib/python3.12/site- packages, /usr/share, /usr/lib, /usr, /usr/share/doc These are spurious diagnostics due to a fedora-review bug. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.12, /usr/lib/python3.12/site-packages, /usr/share, /usr/lib, /usr, /usr/share/doc These are spurious diagnostics due to a fedora-review bug. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2461 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=117723210 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-astropy-iers-data-0.2024.5.13.0.30.12-1.fc41.noarch.rpm python-astropy-iers-data-0.2024.5.13.0.30.12-1.fc41.src.rpm =========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9d905tk1')] checks: 32, packages: 2 python-astropy-iers-data.src: E: description-line-too-long This package provides IERS Earth Rotation and Leap Second tables for the astropy.utils.iers package. python-astropy-iers-data.src: E: description-line-too-long Note: This package is not currently meant to be used directly by users, and only meant to be used from the core Astropy package. python3-astropy-iers-data.noarch: E: description-line-too-long This package provides IERS Earth Rotation and Leap Second tables for the astropy.utils.iers package. python3-astropy-iers-data.noarch: E: description-line-too-long Note: This package is not currently meant to be used directly by users, and only meant to be used from the core Astropy package. ====================================================== 2 packages and 0 specfiles checked; 4 errors, 0 warnings, 9 filtered, 4 badness; has taken 0.9 s ===================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-astropy-iers-data.noarch: E: description-line-too-long This package provides IERS Earth Rotation and Leap Second tables for the astropy.utils.iers package. python3-astropy-iers-data.noarch: E: description-line-too-long Note: This package is not currently meant to be used directly by users, and only meant to be used from the core Astropy package. 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 4 filtered, 2 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/a/astropy_iers_data/astropy_iers_data-0.2024.5.13.0.30.12.tar.gz : CHECKSUM(SHA256) this package : 774894a1bc4cd9f36437354a85d2016539bbf02dd01013d95ca4ac0a1e5643ef CHECKSUM(SHA256) upstream package : 774894a1bc4cd9f36437354a85d2016539bbf02dd01013d95ca4ac0a1e5643ef Requires -------- python3-astropy-iers-data (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-astropy-iers-data: python-astropy-iers-data python3-astropy-iers-data python3.12-astropy-iers-data python3.12dist(astropy-iers-data) python3dist(astropy-iers-data) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -n python-astropy-iers-data --mock-options=--dnf Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Ocaml, Perl, Haskell, SugarActivity, R, fonts, Java, PHP, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2280598 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202280598%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
