https://bugzilla.redhat.com/show_bug.cgi?id=2279008 --- Comment #9 from Dominik Wombacher <dominik@xxxxxxxxxxxx> --- > Thanks for your work! This looks much better. There are just a few remaining things before the package is ready to approve. Thanks for your time and guidance, highly appreciated and a great way to improve my packaging skills :) > Package does not contain duplicates in %files. > Note: warning: File listed twice: /usr/include/s2n > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_duplicate_files > > This: > > %{_includedir}/s2n/ > > packages the directory %{_includedir}/s2n/ and everything under it (files, > directories, whatever). > > Therefore, writing > > %dir %{_includedir}/s2n/ > %{_includedir}/s2n/ > > lists the directory %{_includedir}/s2n twice. > > Please remove these redundant/duplicate entries from the %files: > > %dir %{_includedir}/s2n/ > %dir %{_libdir}/cmake/s2n/ > > Note that > > %dir %{_docdir}/s2n-tls/ > %{_docdir}/s2n-tls/docs/ > > is NOT redundant, because the recursively-packaged directory is a > subdirectory of the directory packaged with %dir. In the current submission, > the base package and the -doc subpackage co-own %{_docdir}/s2n-tls/, which is > exactly correct for how you have things set up. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_the_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function Thanks for that 'aha' moment, I think it finally made click and it becomes clear how and when to use which of them. Adjusted. > It looks like you accidentally made the BuildRequires on openssl-devel > arch-specific by adding %{?_isa}. This is *not* a good idea and is > prohibited, for reasons explained in > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_buildrequires_and_isa. > > Please remove %{?_isa} from > > BuildRequires: openssl-devel%{?_isa} > > and put it on > > %package devel > Summary: %{summary} > Requires: openssl-devel > > instead. Ups, yep somehow I mixed that up, fixed. Let's give it another try :) Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07446826-s2n-tls/s2n-tls.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07446826-s2n-tls/s2n-tls-1.4.14-1.fc41.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2279008 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279008%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
