https://bugzilla.redhat.com/show_bug.cgi?id=2280171 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |dominik@xxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- I suggest replacing all calls to `rm -f` with `rm -v` so that they fail when upstream (re)moves the affected files or directories instead of succeeding silently. Two files seem to have a different license (https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2280171-mpc-qt/fedora-rawhide-x86_64/07437545-mpc-qt/fedora-review/licensecheck.txt): BSD 3-Clause License -------------------- mpc-qt-23.12/lconvert.pri ISC License ----------- mpc-qt-23.12/qthelper.hpp Other than that, it looks fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2280171 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202280171%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
