https://bugzilla.redhat.com/show_bug.cgi?id=2279277 --- Comment #8 from Jaroslav Škarvada <jskarvad@xxxxxxxxxx> --- > > > BuildRequires: gcc make > > Maybe better to add each requirement on individual line. It's better to > > manage and more clear, e.g. you can easily comment out individual deps. > > Unless something very important changes, project like this cannot omit gcc > or make. This does not change anything. > Just minor nit for consistent formatting. With consistent formatting it's also more clear on the quick overview. > > > install -m 0755 %{name} %{buildroot}%{_bindir}/%{name} > > Please use '-p' to preserve time stamps. > > I do not see any point in keeping time stamp of build, which is different on > each rebuild anyway. What is the point for keeping always changing stamp? It > makes perfect sense on content from source archive. Not on always > regenerated build pieces. > The rpm build has multiple phases which are usually run sequentially and without timeout, but they don't need to. Theoretically, there could be any delay between the phases (hours, days) or the phases could run multiple time. E.g. there could be one build phase and multiple install phases. The timestamp should indicate when the binary was build, i.e. when it was created by compiler not when the file was installed. That's the purpose of the '-p' flag. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2279277 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279277%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
