Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mtpaint - Painting program for creating icons and pixel-based artwork https://bugzilla.redhat.com/show_bug.cgi?id=426989 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-01-22 12:42 EST ------- For 3.20-1: * %setup -------------------------------------------------------- %setup -q ....... unzip %{SOURCE1} -------------------------------------------------------- - can be completed by one line: -------------------------------------------------------- %setup -q -a 1 -------------------------------------------------------- * conditional configure option - Would you explain why you don't want to support JPEG 2000? From build.log: -------------------------------------------------------- 277 Use JPEG 2000 NO -------------------------------------------------------- openjpeg-devel is available on Fedora. ! Just Note: || : on %post/%postun - %post/%postun execuses /bin/sh shell script (by default) with "set -x" (not "set -e -x"), so the status of the last command line matters. So if you have to write || : for multiple command lines, you can remove all of them and just write "exit 0" at the last to ensure that %post/%postun doesn't fail. Also, if command is not found, bash simply returns value 127. e.g. http://cvs.fedoraproject.org/viewcvs/*checkout*/devel/alexandria/alexandria.spec * Documents - Please add "COPYING" of mtpaint_handbook zip file to %doc of -handbook subpackage. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review