https://bugzilla.redhat.com/show_bug.cgi?id=2279513 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This looks good! No issues found; the package is APPROVED. Please see below for a note on how a new feature in rust2rpm 26 now allows you to avoid manually modifying the spec file at all. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is almost exactly as generated by rust2rpm with the rust2rpm.toml contents given in https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279513#c0, greatly simplifying the review. Now that we have rust2rpm 26, you can stop doing the modification below manually: --- rust-futures-intrusive.spec 2024-05-10 20:04:26.083384543 -0400 +++ ../srpm-unpacked/rust-futures-intrusive.spec 2024-04-25 20:00:00.000000000 -0400 @@ -14,6 +14,10 @@ Source: %{crates_source} BuildRequires: cargo-rpm-macros >= 24 +# Do downstream crate metadata changes programmatically in %%prep. Since %%prep +# runs before %%generate_buildrequires, we must add the following manually +# rather than generating a dynamic BuildRequires via rust2rpm.toml. +BuildRequires: tomcli %global _description %{expand: Futures based on intrusive data structures - for std and no-std Instead, you can add [requires] build = [ "tomcli", ] and tomcli will now be a regular static BuildRequires (so it will be installed in time to use it in %prep). Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/futures- intrusive-0.5.0/LICENSE-APACHE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is not a serious problem; if it should be fixed, then it should be fixed in rust2rpm. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "MIT License". 44 files have unknown license. Detailed output of licensecheck in /home/ben/Downloads/review/2279513-rust-futures- intrusive/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr, /usr/share, /usr/share/cargo/registry, /usr/share/cargo This diagnostic is a fedora-review bug. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr, /usr/share, /usr/share/cargo/registry, /usr/share/cargo This diagnostic is a fedora-review bug. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- futures-intrusive-devel , rust-futures-intrusive+default-devel , rust- futures-intrusive+alloc-devel , rust-futures-intrusive+parking_lot- devel , rust-futures-intrusive+std-devel [x]: Package functions as described. (tests pass) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=117538605 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-futures-intrusive-devel-0.5.0-1.fc41.noarch.rpm rust-futures-intrusive+default-devel-0.5.0-1.fc41.noarch.rpm rust-futures-intrusive+alloc-devel-0.5.0-1.fc41.noarch.rpm rust-futures-intrusive+parking_lot-devel-0.5.0-1.fc41.noarch.rpm rust-futures-intrusive+std-devel-0.5.0-1.fc41.noarch.rpm rust-futures-intrusive-0.5.0-1.fc41.src.rpm =========================================================================================== rpmlint session starts ========================================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp812yi0va')] checks: 32, packages: 6 rust-futures-intrusive+alloc-devel.noarch: W: no-documentation rust-futures-intrusive+default-devel.noarch: W: no-documentation rust-futures-intrusive+parking_lot-devel.noarch: W: no-documentation rust-futures-intrusive+std-devel.noarch: W: no-documentation ===================================================== 6 packages and 0 specfiles checked; 0 errors, 4 warnings, 27 filtered, 0 badness; has taken 0.4 s ===================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 rust-futures-intrusive+default-devel.noarch: W: no-documentation rust-futures-intrusive+std-devel.noarch: W: no-documentation rust-futures-intrusive+alloc-devel.noarch: W: no-documentation rust-futures-intrusive+parking_lot-devel.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 4 warnings, 23 filtered, 0 badness; has taken 0.2 s Source checksums ---------------- https://crates.io/api/v1/crates/futures-intrusive/0.5.0/download#/futures-intrusive-0.5.0.crate : CHECKSUM(SHA256) this package : 1d930c203dd0b6ff06e0201a4a2fe9149b43c684fd4420555b26d21b1a02956f CHECKSUM(SHA256) upstream package : 1d930c203dd0b6ff06e0201a4a2fe9149b43c684fd4420555b26d21b1a02956f Requires -------- rust-futures-intrusive-devel (rpmlib, GLIBC filtered): (crate(futures-core) >= 0.3.0 with crate(futures-core) < 0.4.0~) (crate(lock_api/default) >= 0.4.1 with crate(lock_api/default) < 0.5.0~) cargo rust-futures-intrusive+default-devel (rpmlib, GLIBC filtered): cargo crate(futures-intrusive) crate(futures-intrusive/std) rust-futures-intrusive+alloc-devel (rpmlib, GLIBC filtered): (crate(futures-core/alloc) >= 0.3.0 with crate(futures-core/alloc) < 0.4.0~) cargo crate(futures-intrusive) rust-futures-intrusive+parking_lot-devel (rpmlib, GLIBC filtered): (crate(parking_lot/default) >= 0.12.0 with crate(parking_lot/default) < 0.13.0~) cargo crate(futures-intrusive) rust-futures-intrusive+std-devel (rpmlib, GLIBC filtered): cargo crate(futures-intrusive) crate(futures-intrusive/alloc) crate(futures-intrusive/parking_lot) Provides -------- rust-futures-intrusive-devel: crate(futures-intrusive) rust-futures-intrusive-devel rust-futures-intrusive+default-devel: crate(futures-intrusive/default) rust-futures-intrusive+default-devel rust-futures-intrusive+alloc-devel: crate(futures-intrusive/alloc) rust-futures-intrusive+alloc-devel rust-futures-intrusive+parking_lot-devel: crate(futures-intrusive/parking_lot) rust-futures-intrusive+parking_lot-devel rust-futures-intrusive+std-devel: crate(futures-intrusive/std) rust-futures-intrusive+std-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2279513 --mock-options=--dnf Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, PHP, Java, SugarActivity, Haskell, Ocaml, C/C++, fonts, Perl, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2279513 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279513%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
